From owner-svn-src-all@freebsd.org  Thu May 24 14:24:02 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5CE8AEF2C5A;
 Thu, 24 May 2018 14:24:02 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D1BD16E22A;
 Thu, 24 May 2018 14:24:01 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w4OENrpF040656;
 Thu, 24 May 2018 07:23:53 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w4OENrjU040655;
 Thu, 24 May 2018 07:23:53 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201805241423.w4OENrjU040655@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r334129 - head/sys/amd64/conf
In-Reply-To: <CAPyFy2AcDG57FCfRErCRdvpAAWSrkZO6mdfgioY_Sj1owmXhBw@mail.gmail.com>
To: Ed Maste <emaste@freebsd.org>
Date: Thu, 24 May 2018 07:23:53 -0700 (PDT)
CC: src-committers <src-committers@freebsd.org>, svn-src-head@freebsd.org,
 svn-src-all@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 May 2018 14:24:02 -0000

> On 24 May 2018 at 01:36, Matthew Macy <mmacy@freebsd.org> wrote:
> > On Wed, May 23, 2018 at 10:32 PM, Ravi Pokala <rpokala@freebsd.org> wrote:
> >>>
> >>> Author: mmacy
> >>> Date: Thu May 24 04:31:53 2018
> >>> New Revision: 334129
> >>> URL: https://svnweb.freebsd.org/changeset/base/334129
> >>>
> >>> Log:
> >>>   take NUMA out
> >>> ...
> >> Why?
> >
> >
> > I ^C'd the prior commit too late.
> 
> For cases like this the commit message should include something like
> "It was accidentally committed in r334128."

Would it not make some sense to revert and recommit when these happen,
especially if there is an intenent to MFC, otherwise one has to be
sure to merge both parts to end up with a corrected commit to stable/

We seem to be afraid of revert, recommit correcting cycles,
and in the long run that may be causing us some problems.

Just a though.

-- 
Rod Grimes                                                 rgrimes@freebsd.org