Date: Fri, 3 Nov 2017 16:45:17 -0600 From: Warner Losh <imp@bsdimp.com> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r325116 - head Message-ID: <CANCZdfr6s0wWs%2BjYCVjAVEj0c_=5PGGz%2BnU-u8O61snNQjPKkQ@mail.gmail.com> In-Reply-To: <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> References: <201710300312.v9U3CcCT021416@repo.freebsd.org> <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> <CANCZdfpXuLkS843%2BjneBzCYCsM5ZvV_Tm=zxzt73-wiD3C2%2BLg@mail.gmail.com> <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 3, 2017 at 4:40 PM, Bryan Drewery <bdrewery@freebsd.org> wrote: > On 11/3/2017 3:32 PM, Warner Losh wrote: > > > > > > On Fri, Nov 3, 2017 at 4:28 PM, Bryan Drewery <bdrewery@freebsd.org > > <mailto:bdrewery@freebsd.org>> wrote: > > > > On 10/29/2017 8:12 PM, Warner Losh wrote: > > > Author: imp > > > Date: Mon Oct 30 03:12:38 2017 > > > New Revision: 325116 > > > URL: https://svnweb.freebsd.org/changeset/base/325116 > > <https://svnweb.freebsd.org/changeset/base/325116>; > > > > > > Log: > > > Return proper status from buildenv. > > > > > > make buildenv BUILDENV_SHELL=<some command> more useful. Remove > '|| > > > true' from the command line so that errors are properly > > > returned. There appears to be no reason for it, and it dates > back to > > > the original commit by ru@. > > > > > > Sponsored by: Netflix > > > > Now simply running 'make buildenv' and 'exit' throws a make error. > > > > Perhaps we need a BUILDENV_CMDS that does what you want and we > otherwise > > leave the ${BUILDENV_SHELL} || true handling. > > > > > > Are you sure? > > > > 4:29pm zooty:[242]> make buildenv > > Entering world for amd64:amd64 > > $ exit > > 4:29pm zooty:[243]> > > > > Perhaps you can give me an example that causes that? This was the very > > first thing I checked before committing the fix... > > > > Only happens with zsh. > > > [root@c1100-1][pts/8][zsh/2][Fri 11/03/2017 15:40:10 PDT][0?2&] > (git-svn)-[master]- > > ~/git/freebsd # BUILDENV_SHELL=csh make buildenv > > Entering world for amd64:amd64 > > root@c1100-1:~/git/freebsd # exit > > exit > > ~/git/freebsd # BUILDENV_SHELL=/usr/local/bin/zsh make buildenv > > Entering world for amd64:amd64 > > For ZSH you must run: export CPUTYPE= > > (buildenv) [root@c1100-1][pts/8][zsh/3][Fri 11/03/2017 15:40:23 > PDT][1?0&] (git-svn)-[master]- > > ~/git/freebsd # exit > > *** Error code 1 > > > > Stop. > > make[1]: stopped in /root/git/freebsd > > *** Error code 1 > > > > Stop. > > make: stopped in /root/git/freebsd > Shouldn't this be fixed in upstream zsh rather than yet another ZSH wart in the buildsystem that literally has another ZSH wart in the same line? Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr6s0wWs%2BjYCVjAVEj0c_=5PGGz%2BnU-u8O61snNQjPKkQ>