From owner-svn-ports-head@FreeBSD.ORG  Sat Jul 27 17:26:27 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id E651D823;
 Sat, 27 Jul 2013 17:26:27 +0000 (UTC)
 (envelope-from andrej.zverev@gmail.com)
Received: from mail-oa0-x235.google.com (mail-oa0-x235.google.com
 [IPv6:2607:f8b0:4003:c02::235])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 87FED2DA0;
 Sat, 27 Jul 2013 17:26:27 +0000 (UTC)
Received: by mail-oa0-f53.google.com with SMTP id k14so10181051oag.12
 for <multiple recipients>; Sat, 27 Jul 2013 10:26:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=D98KGxjbKM183FquzokHKBKAXhGHKxIuUhMfq5/H4ZQ=;
 b=U2ok5VHVyatJHeVP8vucdJB2KhgF4COb+UVGYnCh9RnXEgwDS7l8Kcs4yBrbN1NQm6
 Z/Pwgn8hx7h8537LxXckcQjBfXeF7kQAiBFzLSWPYyFL682uPG6cRCCuBrF0zOQrFjhA
 E4kuCeKx0Ypn4C7oROY93321uLsnZsPpbscuakagVA8xhWnX4VQrUjvX9GYUCWQEggL1
 q4zBmkXg3hwQdAsgf3ucm9JaFARoRK/FUN0PNDToXeSleHE+eWmyaTdp41Kabi9EMs+d
 XzPyX/XrXBxvGzAZfGFnXDa6+gK9GEBFrxFXSKVlCO2sIAsLggErfNE6KHe5jMtKVd53
 cCow==
MIME-Version: 1.0
X-Received: by 10.60.131.171 with SMTP id on11mr52958162oeb.71.1374945986745; 
 Sat, 27 Jul 2013 10:26:26 -0700 (PDT)
Sender: andrej.zverev@gmail.com
Received: by 10.182.118.100 with HTTP; Sat, 27 Jul 2013 10:26:26 -0700 (PDT)
In-Reply-To: <20130727172056.GA95369@FreeBSD.org>
References: <201307271606.r6RG6PoL038173@svn.freebsd.org>
 <20130727162504.GA78281@FreeBSD.org>
 <CAD5bB+jewTn+B301gtkr1BVmSQsU+D7wy2We=bcd5ZsX=2y-cw@mail.gmail.com>
 <20130727172056.GA95369@FreeBSD.org>
Date: Sat, 27 Jul 2013 21:26:26 +0400
X-Google-Sender-Auth: n6wMOzp1NjmXKapyIkwDsSaKNZU
Message-ID: <CAD5bB+g6WqtM89M09G_JBnSN=8=EBsq06BBbi6wR5LB0JPCR6g@mail.gmail.com>
Subject: Re: svn commit: r323795 - in head: audio/mp32ogg audio/p5-Shout
 databases/p5-DBD-InterBase databases/p5-DBIx-Class-TimeStamp
 databases/p5-DBIx-MySQLSequence devel/cvslines devel/cvsplot devel/cvsstat
 d...
From: Andrej Zverev <az@freebsd.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jul 2013 17:26:28 -0000

On Sat, Jul 27, 2013 at 9:20 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Sat, Jul 27, 2013 at 09:10:47PM +0400, Andrej Zverev wrote:
>> On Sat, Jul 27, 2013 at 8:25 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
>> > On Sat, Jul 27, 2013 at 04:06:25PM +0000, Andrej Zverev wrote:
>> >> New Revision: 323795
>> >> URL: http://svnweb.freebsd.org/changeset/ports/323795
>> >>
>> >> @@ -32,7 +29,7 @@ NO_BUILD=   yes
>> >>  PLIST_FILES= bin/mp32ogg
>> >>
>> >>  post-patch:
>> >> -     @${PERL} -pi -e "s,%%LOCALBASE%%,${LOCALBASE},g" ${WRKSRC}/mp32ogg
>> >> +     @${REINPLACE_CMD} -i '' -e 's|%%LOCALBASE%%|${LOCALBASE}|' [...]
>> >
>> > Andrej, can you clarify why explicit -i '' is needed here and quite a few
>> > other ports in the commit?  Is it because of otherwise .bak files will be
>> > installed?  Just looks weird to see these args all over the place...
>>
>> Yes, thats a reason. I don't see (personally) why REPLACE ARGS default
>> with -i.bak, but overriding port Makefile everytime really annoying :(
>
> Understood, thanks for clarification.
>
> ./danfe
>
> P.S.  Personally I like having those .bak files around, because it makes
> debugging (via diff'ing) so much easier.  Not related to the commit, but
> just in case someone(tm) would have an idea to suppress them by default.
> Please don't.  Thank yo

I agree, but I'm just changing tool (in this task). With the .bak by
default I would have to do a full test to make sure there are no
remaining leftovers. It would take a couple of weeks. Next time I'll
try do my best as you suggested.