From owner-freebsd-arm@freebsd.org  Wed Jul 15 10:47:21 2015
Return-Path: <owner-freebsd-arm@freebsd.org>
Delivered-To: freebsd-arm@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BBD489A1ECE
 for <freebsd-arm@mailman.ysv.freebsd.org>;
 Wed, 15 Jul 2015 10:47:21 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 by mx1.freebsd.org (Postfix) with ESMTP id A33291F1D
 for <freebsd-arm@freebsd.org>; Wed, 15 Jul 2015 10:47:21 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346)
 id 92284EED3; Wed, 15 Jul 2015 10:47:21 +0000 (UTC)
Date: Wed, 15 Jul 2015 10:47:21 +0000
To: freebsd-arm@freebsd.org
From: "wma_semihalf.com (Wojciech Macek)" <phabric-noreply@FreeBSD.org>
Reply-to: D3093+327+2a07f7966a36d8e6@FreeBSD.org
Subject: [Differential] [Commented On] D3093: ARMv8 locore.S cleanup and TCR
 register update
Message-ID: <7c48c367946946db0109fa5f94d00c59@localhost.localdomain>
X-Priority: 3
Thread-Topic: D3093: ARMv8 locore.S cleanup and TCR register update
X-Herald-Rules: <28>, <31>, <32>, <34>
X-Phabricator-To: <PHID-USER-u7g3pamdppe4sw6i6zt6>
X-Phabricator-To: <PHID-USER-6m5mo2kjikkzyd33ld4n>
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-Cc: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-Cc: <PHID-USER-wjsgsqx4il4yblud7x6c>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
In-Reply-To: <differential-rev-PHID-DREV-qvctvfcls3krqccl2a3p-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-qvctvfcls3krqccl2a3p-req@FreeBSD.org>
Thread-Index: MzBhZGMyZWQyNmZmNjgwMWZjYjI4ZThlZTAzIFWmOjk=
Precedence: bulk
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2015 10:47:21 -0000

wma_semihalf.com added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/locore.S:48-52 You're right, I'll remove it prior submitting.
  sys/arm64/arm64/locore.S:191 It's the part of locore fixes described in the patch summary
  > - secondary stack calculation is modified to provide
  >  stack_top = secondary_stacks + (cpu_id)*PAGE_SIZE*KSTACK_PAGES
  >   because on ARMv8 the stack grows into lower memory addresses
  
  Please let me know if I should split this patch into two (include+stack and TCR reg) or leave as a one.

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D3093

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: wma_semihalf.com, zbb, emaste, andrew
Cc: imp, andrew, freebsd-arm-list, emaste