From owner-svn-src-all@freebsd.org Thu Nov 29 18:37:51 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3ED311148A5E; Thu, 29 Nov 2018 18:37:51 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D572E7C48C; Thu, 29 Nov 2018 18:37:50 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B4E171D5AF; Thu, 29 Nov 2018 18:37:50 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id wATIbott096051; Thu, 29 Nov 2018 18:37:50 GMT (envelope-from sobomax@FreeBSD.org) Received: (from sobomax@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id wATIbmRi096041; Thu, 29 Nov 2018 18:37:48 GMT (envelope-from sobomax@FreeBSD.org) Message-Id: <201811291837.wATIbmRi096041@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: sobomax set sender to sobomax@FreeBSD.org using -f From: Maxim Sobolev Date: Thu, 29 Nov 2018 18:37:48 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r341253 - in head/stand: common i386/libi386 libsa uboot/lib X-SVN-Group: head X-SVN-Commit-Author: sobomax X-SVN-Commit-Paths: in head/stand: common i386/libi386 libsa uboot/lib X-SVN-Commit-Revision: 341253 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D572E7C48C X-Spamd-Result: default: False [0.95 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_SPAM_SHORT(0.30)[0.304,0]; NEURAL_SPAM_MEDIUM(0.31)[0.312,0]; NEURAL_SPAM_LONG(0.34)[0.335,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 18:37:51 -0000 Author: sobomax Date: Thu Nov 29 18:37:48 2018 New Revision: 341253 URL: https://svnweb.freebsd.org/changeset/base/341253 Log: The libstand's panic() appends its own '\n' to the message, so that users of the API don't need to supply one. MFC after: 2 weeks Modified: head/stand/common/interp_forth.c head/stand/i386/libi386/biosdisk.c head/stand/libsa/arp.c head/stand/libsa/assert.c head/stand/libsa/bzipfs.c head/stand/libsa/netif.c head/stand/libsa/sbrk.c head/stand/uboot/lib/copy.c head/stand/uboot/lib/net.c Modified: head/stand/common/interp_forth.c ============================================================================== --- head/stand/common/interp_forth.c Thu Nov 29 18:02:35 2018 (r341252) +++ head/stand/common/interp_forth.c Thu Nov 29 18:37:48 2018 (r341253) @@ -144,7 +144,7 @@ bf_command(FICL_VM *vm) printf("%s\n", command_errmsg); break; case CMD_FATAL: - panic("%s\n", command_errmsg); + panic("%s", command_errmsg); } free(line); Modified: head/stand/i386/libi386/biosdisk.c ============================================================================== --- head/stand/i386/libi386/biosdisk.c Thu Nov 29 18:02:35 2018 (r341252) +++ head/stand/i386/libi386/biosdisk.c Thu Nov 29 18:37:48 2018 (r341253) @@ -646,7 +646,7 @@ bd_realstrategy(void *devdata, int rw, daddr_t dblk, s } if (V86_IO_BUFFER_SIZE / BD(dev).bd_sectorsize == 0) - panic("BUG: Real mode buffer is too small\n"); + panic("BUG: Real mode buffer is too small"); bbuf = PTOV(V86_IO_BUFFER); rest = size; Modified: head/stand/libsa/arp.c ============================================================================== --- head/stand/libsa/arp.c Thu Nov 29 18:02:35 2018 (r341252) +++ head/stand/libsa/arp.c Thu Nov 29 18:37:48 2018 (r341253) @@ -120,7 +120,7 @@ arpwhohas(struct iodesc *d, struct in_addr addr) arpsend, &wbuf.data, sizeof(wbuf.data), arprecv, &pkt, (void **)&ah, NULL); if (i == -1) { - panic("arp: no response for %s\n", + panic("arp: no response for %s", inet_ntoa(addr)); } Modified: head/stand/libsa/assert.c ============================================================================== --- head/stand/libsa/assert.c Thu Nov 29 18:02:35 2018 (r341252) +++ head/stand/libsa/assert.c Thu Nov 29 18:37:48 2018 (r341253) @@ -35,10 +35,10 @@ void __assert(const char *func, const char *file, int line, const char *expression) { if (func == NULL) - panic("Assertion failed: (%s), file %s, line %d.\n", + panic("Assertion failed: (%s), file %s, line %d.", expression, file, line); else panic( - "Assertion failed: (%s), function %s, file %s, line %d.\n", + "Assertion failed: (%s), function %s, file %s, line %d.", expression, func, file, line); } Modified: head/stand/libsa/bzipfs.c ============================================================================== --- head/stand/libsa/bzipfs.c Thu Nov 29 18:02:35 2018 (r341252) +++ head/stand/libsa/bzipfs.c Thu Nov 29 18:37:48 2018 (r341253) @@ -360,7 +360,7 @@ bzf_stat(struct open_file *f, struct stat *sb) void bz_internal_error(int errorcode) { - panic("bzipfs: critical error %d in bzip2 library occured\n", errorcode); + panic("bzipfs: critical error %d in bzip2 library occured", errorcode); } #ifdef REGRESSION Modified: head/stand/libsa/netif.c ============================================================================== --- head/stand/libsa/netif.c Thu Nov 29 18:02:35 2018 (r341252) +++ head/stand/libsa/netif.c Thu Nov 29 18:37:48 2018 (r341253) @@ -182,7 +182,7 @@ netif_attach(struct netif *nif, struct iodesc *desc, v desc->io_netif = nif; #ifdef PARANOID if (drv->netif_init == NULL) - panic("%s%d: no netif_init support\n", drv->netif_bname, + panic("%s%d: no netif_init support", drv->netif_bname, nif->nif_unit); #endif drv->netif_init(desc, machdep_hint); @@ -201,7 +201,7 @@ netif_detach(struct netif *nif) #endif #ifdef PARANOID if (drv->netif_end == NULL) - panic("%s%d: no netif_end support\n", drv->netif_bname, + panic("%s%d: no netif_end support", drv->netif_bname, nif->nif_unit); #endif drv->netif_end(nif); @@ -222,7 +222,7 @@ netif_get(struct iodesc *desc, void **pkt, time_t timo #endif #ifdef PARANOID if (drv->netif_get == NULL) - panic("%s%d: no netif_get support\n", drv->netif_bname, + panic("%s%d: no netif_get support", drv->netif_bname, nif->nif_unit); #endif rv = drv->netif_get(desc, pkt, timo); @@ -249,7 +249,7 @@ netif_put(struct iodesc *desc, void *pkt, size_t len) #endif #ifdef PARANOID if (drv->netif_put == NULL) - panic("%s%d: no netif_put support\n", drv->netif_bname, + panic("%s%d: no netif_put support", drv->netif_bname, nif->nif_unit); #endif rv = drv->netif_put(desc, pkt, len); Modified: head/stand/libsa/sbrk.c ============================================================================== --- head/stand/libsa/sbrk.c Thu Nov 29 18:02:35 2018 (r341252) +++ head/stand/libsa/sbrk.c Thu Nov 29 18:37:48 2018 (r341253) @@ -53,7 +53,7 @@ sbrk(int incr) char *ret; if (heapbase == 0) - panic("No heap setup\n"); + panic("No heap setup"); if ((heapsize + incr) <= maxheap) { ret = (char *)heapbase + heapsize; Modified: head/stand/uboot/lib/copy.c ============================================================================== --- head/stand/uboot/lib/copy.c Thu Nov 29 18:02:35 2018 (r341252) +++ head/stand/uboot/lib/copy.c Thu Nov 29 18:37:48 2018 (r341253) @@ -133,7 +133,7 @@ uboot_loadaddr(u_int type, void *data, uint64_t addr) } } if (biggest_size == 0) - panic("Not enough DRAM to load kernel\n"); + panic("Not enough DRAM to load kernel"); #if 0 printf("Loading kernel into region 0x%08jx-0x%08jx (%ju MiB)\n", (uintmax_t)biggest_block, Modified: head/stand/uboot/lib/net.c ============================================================================== --- head/stand/uboot/lib/net.c Thu Nov 29 18:02:35 2018 (r341252) +++ head/stand/uboot/lib/net.c Thu Nov 29 18:37:48 2018 (r341253) @@ -324,7 +324,7 @@ net_init(struct iodesc *desc, void *machdep_hint) sc = nif->nif_devdata = &uboot_softc; if ((err = ub_dev_open(sc->sc_handle)) != 0) - panic("%s%d: initialisation failed with error %d\n", + panic("%s%d: initialisation failed with error %d", nif->nif_driver->netif_bname, nif->nif_unit, err); /* Get MAC address */ @@ -359,6 +359,6 @@ net_end(struct netif *nif) int err; if ((err = ub_dev_close(sc->sc_handle)) != 0) - panic("%s%d: net_end failed with error %d\n", + panic("%s%d: net_end failed with error %d", nif->nif_driver->netif_bname, nif->nif_unit, err); }