From owner-svn-src-all@freebsd.org Wed May 18 15:50:52 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8CB17B410BC; Wed, 18 May 2016 15:50:52 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5AC0F1DC9; Wed, 18 May 2016 15:50:52 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-io0-x22c.google.com with SMTP id d62so70531030iof.2; Wed, 18 May 2016 08:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lvWmyqauENI7UXF8vTrUu5il1E/YyHvTWgJCPzE+gKc=; b=0oJ1tg5/W301EdKM9LMfUwyaND7BdAcUhXGPWLC1688hfvllqPPs2ssadF7BsNNjx1 XbBdv6VvuMjYyr2nYMr+C4evB0GOpdrlQGuFzLsh/zcX8wuS0uc57ed+U0+a9yWO0BMS fFAJp+WTZywocLzGrdJ/V5QDEjv16mErpjv/fIUUedRH77rYCtEj63CbtXEsDeGnnhld qZSmfmwVecS9irJbyyklYmUYp0APTLkOnSYuPChVZuytXzyoguO5N4hmiRs6HeMVA7hy LEqmjQSUsggdT+CcbE3bICNnpZaO0xalXqIjTN/IBLpYzT80J1IJokH3cca/ToMV5UzT dBSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lvWmyqauENI7UXF8vTrUu5il1E/YyHvTWgJCPzE+gKc=; b=BapitTVBzI+LpUQfwhUn8nFNW2LVGZJIExEtcT83cTByzfjuGIm11X6pZhX6S0fFfc JreTBeAPQ7HgdWrZh8baDL1o/H3XXizmUu82mDEzL3oUQIHdxlChTy8qYCJkXJR7/t3V MsKBswM0RJwVNDINfCB0w9gLeJjRU3JCOTXNK0sNTDVcQ9cEsznbYGsW2J3cdFGHaeZu cCGG/AjErQmOjcjby709hbWUmlptvGtFx5s7Z2WJPRGc3ntwhHyhIff/8CJn/WsEOxoy lXhLisOBFS6CISC/dXlTIJd8Yzwur76iN06QKqYXINwnL+/l9DEYYLn1oRhvG9do/+jY uTaA== X-Gm-Message-State: AOPr4FVxm8oYuLHHHpOyUvbosJU01yrrVNedBh0jXIP3nYLJFlxX01YtmCVN2Gx4VO2QJQ== X-Received: by 10.107.10.37 with SMTP id u37mr5657380ioi.92.1463586651643; Wed, 18 May 2016 08:50:51 -0700 (PDT) Received: from zhabar.knownspace (173-29-11-18.client.mchsi.com. [173.29.11.18]) by smtp.gmail.com with ESMTPSA id z6sm9009082igg.21.2016.05.18.08.50.51 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 May 2016 08:50:51 -0700 (PDT) Date: Wed, 18 May 2016 10:50:33 -0500 From: Justin Hibbits To: Scott Long Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300154 - head/sys/net Message-ID: <20160518105033.1eae7432@zhabar.knownspace> In-Reply-To: <201605181545.u4IFjCKD030751@repo.freebsd.org> References: <201605181545.u4IFjCKD030751@repo.freebsd.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; powerpc64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2016 15:50:52 -0000 On Wed, 18 May 2016 15:45:12 +0000 (UTC) Scott Long wrote: > Author: scottl > Date: Wed May 18 15:45:12 2016 > New Revision: 300154 > URL: https://svnweb.freebsd.org/changeset/base/300154 > > Log: > Activate the NO_64BIT_ATOMICS code for mips and powerpc > > Modified: > head/sys/net/mp_ring.c > > Modified: head/sys/net/mp_ring.c > ============================================================================== > --- head/sys/net/mp_ring.c Wed May 18 15:44:45 2016 > (r300153) +++ head/sys/net/mp_ring.c Wed May 18 15:45:12 > 2016 (r300154) @@ -37,15 +37,17 @@ __FBSDID("$FreeBSD$"); > #include > #include > > - > - > -#include > +#if defined(__powerpc__) || defined(__mips__) > +#define NO_64BIT_ATOMICS > +#endif > > #if defined(__i386__) > #define atomic_cmpset_acq_64 atomic_cmpset_64 > #define atomic_cmpset_rel_64 atomic_cmpset_64 > #endif > > +#include > + > union ring_state { > struct { > uint16_t pidx_head; > powerpc64 defines both __powerpc__ and __powerpc64__, so you're killing atomics on powerpc64 with this. - Justin