Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 11 Apr 2018 20:02:24 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r332417 - in user/markj/netdump/sys: kern netinet/netdump sys
Message-ID:  <201804112002.w3BK2ObC098899@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: markj
Date: Wed Apr 11 20:02:24 2018
New Revision: 332417
URL: https://svnweb.freebsd.org/changeset/base/332417

Log:
  Remove the unneeded EXT_NETDUMP.

Modified:
  user/markj/netdump/sys/kern/kern_mbuf.c
  user/markj/netdump/sys/netinet/netdump/netdump_client.c
  user/markj/netdump/sys/sys/mbuf.h

Modified: user/markj/netdump/sys/kern/kern_mbuf.c
==============================================================================
--- user/markj/netdump/sys/kern/kern_mbuf.c	Wed Apr 11 19:46:24 2018	(r332416)
+++ user/markj/netdump/sys/kern/kern_mbuf.c	Wed Apr 11 20:02:24 2018	(r332417)
@@ -867,7 +867,6 @@ mb_free_ext(struct mbuf *m)
 		case EXT_NET_DRV:
 		case EXT_MOD_TYPE:
 		case EXT_DISPOSABLE:
-		case EXT_NETDUMP:
 			KASSERT(mref->m_ext.ext_free != NULL,
 			    ("%s: ext_free not set", __func__));
 			mref->m_ext.ext_free(mref);

Modified: user/markj/netdump/sys/netinet/netdump/netdump_client.c
==============================================================================
--- user/markj/netdump/sys/netinet/netdump/netdump_client.c	Wed Apr 11 19:46:24 2018	(r332416)
+++ user/markj/netdump/sys/netinet/netdump/netdump_client.c	Wed Apr 11 20:02:24 2018	(r332417)
@@ -368,7 +368,7 @@ restart:
 }
 
 /*
- * Dummy free function for EXT_NETDUMP clusters.
+ * Dummy free function for netdump clusters.
  */
 static void
 netdump_mbuf_free(struct mbuf *m __unused)
@@ -454,7 +454,7 @@ retransmit:
 				return (ENOBUFS);
 			}
 			MEXTADD(m2, data + sent_so_far, pktlen,
-			    netdump_mbuf_free, NULL, NULL, 0, EXT_NETDUMP);
+			    netdump_mbuf_free, NULL, NULL, 0, EXT_DISPOSABLE);
 			m2->m_len = pktlen;
 
 			m_cat(m, m2);

Modified: user/markj/netdump/sys/sys/mbuf.h
==============================================================================
--- user/markj/netdump/sys/sys/mbuf.h	Wed Apr 11 19:46:24 2018	(r332416)
+++ user/markj/netdump/sys/sys/mbuf.h	Wed Apr 11 20:02:24 2018	(r332417)
@@ -438,7 +438,6 @@ struct mbuf {
 #define	EXT_JUMBO16	5	/* jumbo cluster 16184 bytes */
 #define	EXT_PACKET	6	/* mbuf+cluster from packet zone */
 #define	EXT_MBUF	7	/* external mbuf reference */
-#define	EXT_NETDUMP	8	/* network kernel dump */
 
 #define	EXT_VENDOR1	224	/* for vendor-internal use */
 #define	EXT_VENDOR2	225	/* for vendor-internal use */

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804112002.w3BK2ObC098899>