From owner-svn-src-head@FreeBSD.ORG  Tue Apr 12 12:58:31 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2D396106566C;
	Tue, 12 Apr 2011 12:58:31 +0000 (UTC)
	(envelope-from hselasky@freebsd.org)
Received: from swip.net (mailfe07.c2i.net [212.247.154.194])
	by mx1.freebsd.org (Postfix) with ESMTP id 542908FC16;
	Tue, 12 Apr 2011 12:58:29 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.1 cv=118a5bn0tGnRZbUa9ClBty6BTuM1bA5mUZqmf2RHYp4=
	c=1 sm=1 a=IU0TiZmyZPMA:10 a=QSUqwWVUwJMA:10 a=dBRESv0yCI8A:10
	a=N659UExz7-8A:10 a=CL8lFSKtTFcA:10
	a=i9M/sDlu2rpZ9XS819oYzg==:17 a=6I5d2MoRAAAA:8
	a=yGPF2y0DA6eK0P-p5tsA:9 a=pILNOxqGKmIA:10
	a=i9M/sDlu2rpZ9XS819oYzg==:117
Received: from [188.126.198.129] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe07.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 113062455; Tue, 12 Apr 2011 14:58:28 +0200
Received-SPF: softfail receiver=mailfe07.swip.net; client-ip=188.126.198.129;
	envelope-from=hselasky@freebsd.org
From: Hans Petter Selasky <hselasky@freebsd.org>
To: Nathan Whitehorn <nwhitehorn@freebsd.org>
Date: Tue, 12 Apr 2011 14:57:26 +0200
User-Agent: KMail/1.13.5 (FreeBSD/8.2-PRERELEASE; KDE/4.4.5; amd64; ; )
References: <201104120749.p3C7nBDQ014198@svn.freebsd.org>
	<4DA447F7.50104@freebsd.org>
In-Reply-To: <4DA447F7.50104@freebsd.org>
X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5
	%V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC(
	:AuzV9:.hESm-x4h240C`9=w
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="windows-1252"
Content-Transfer-Encoding: 7bit
Message-Id: <201104121457.26348.hselasky@freebsd.org>
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
	"svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
	"src-committers@freebsd.org" <src-committers@freebsd.org>
Subject: Re: svn commit: r220558 - in head/sys: arm/econa dev/usb/controller
	mips/atheros mips/rmi
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Apr 2011 12:58:31 -0000

On Tuesday 12 April 2011 14:39:19 Nathan Whitehorn wrote:
> On 04/12/11 02:49, Hans Petter Selasky wrote:
> > Author: hselasky
> > Date: Tue Apr 12 07:49:11 2011
> > New Revision: 220558
> > URL: http://svn.freebsd.org/changeset/base/220558
> > 
> > Log:
> >    We don't need to call EOWRITE4(sc, EHCI_USBINTR, 0) directly from each
> >    EHCI bus driver at detach, hence ehci_detach() does exactly this
> >    since r199718.
> 
> Just so you're aware, there's also another EHCI driver in the tree at
> /sys/powerpc/ps3/ehci_ps3.c. It might also need some modifications at
> various points when you're cleaning up EHCI drivers.

This driver doesn't have a detach method. The patches don't apply to this 
driver then. Should I add a detach method or is it superfluous?

Thanks for noticing!

--HPS