From owner-svn-src-all@freebsd.org Thu Feb 23 17:46:28 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32167CEB2F4 for ; Thu, 23 Feb 2017 17:46:28 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm10-vm2.bullet.mail.ne1.yahoo.com (nm10-vm2.bullet.mail.ne1.yahoo.com [98.138.90.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 03F3623B for ; Thu, 23 Feb 2017 17:46:27 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1487871980; bh=TLysBI1XhbudB7XPzv/toIR0YgMxnsnBUFWqw5dv7YY=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=kk1bo45Mmfz0FjhmdkwIOJO4BvGUZ1KH/pDfcg+R60W6wPfiFD1B7ZblTGnVilUaq2GEMEB2a4ApAn71ozIVH6asKvEGOE5LMJdcQmQvF4xoEl/NJLcvF4lKw3fPUMiAMdm8qfHwhA3EpfqMQ/JJXeJ0CEEKdvrFuzXnZke/AOm93Mx/JKv/6xDQjaZ/GWPSok9SrN9ls5I+HxwePh4ZZZOQ6O6Kz9BCftdYxCZN8rlFERWOg8GB6+9F7PkxsmOubKSX9EW3DejSWcCwqM0Z6NAbtb1CWeI4e7HMXDpCxY4ol8rBPgFQJWKXPi7QCvUBwGiVKhYzaPnk3ds+XxiIMg== Received: from [98.138.100.116] by nm10.bullet.mail.ne1.yahoo.com with NNFMP; 23 Feb 2017 17:46:20 -0000 Received: from [98.138.84.37] by tm107.bullet.mail.ne1.yahoo.com with NNFMP; 23 Feb 2017 17:46:20 -0000 Received: from [127.0.0.1] by smtp105.mail.ne1.yahoo.com with NNFMP; 23 Feb 2017 17:46:20 -0000 X-Yahoo-Newman-Id: 905926.17662.bm@smtp105.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: vBxXYdIVM1l1_vOL.memx1Kned1iobPeCSwLHpkDNZPRe_U 6KtNNI3BTUU_d4CimdbY05ES6YVfD1RC2iO_rp7ypJYQT2T9ByLQYgU5JEYd cIA4IA5v3vbpHoreENavUi2bljvhna2YL.kwyPTqHfAHicLg.XcEGuPMwv3Y DKd4MSqvIUl.AIbgsCUXy0l.b0WaTLiGUaCA5JJgcxADdRnwlnjznaE2ig3Y GK3A5Ybmoe0cjHroNpXWSzJ2y8bWQetMPeVtRT2gDtSWzzCbE.8IRGoOQEsY 9n94cEZs4Fu5oFGarvQ4dNldHsKacKtTPIj25lvUgHOkW6sO5RGWmLpPKDUP vvBiUgsjucMElwZ0QLKqEQ.Y1H8icnQgP_sMtJjGB0.cbunSXjUSQ27ss7R9 vFf17UGR2yGwynlWmuR.jO1Ct000NGqR8iAbcjg_.EUZhO9SUigb3Ha5Gkri fBjHNNgpFSP3F6aQ6jj2hEvhkgZyolORbUIcho0Xt.o6pm_xBudFNht6jc5H h6va1hRyPoentOG1cZDUhuGSFidppLYJdA6.Cm60fH9YJsSs- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r314142 - head/sys/dev/ce To: Benjamin Kaduk References: <201702231530.v1NFULwx024028@repo.freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Pedro Giffuni Message-ID: Date: Thu, 23 Feb 2017 12:49:01 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 17:46:28 -0000 On 2/23/2017 12:13 PM, Benjamin Kaduk wrote: > On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni > wrote: > > Author: pfg > Date: Thu Feb 23 15:30:21 2017 > New Revision: 314142 > URL: https://svnweb.freebsd.org/changeset/base/314142 > > > Log: > dev/ce: double assignment. > > The code is not operational right now so just comment away an > obviously > useless assignment. Fix some typos while here. > > Found with: coccinelle (da.cocci) > > Modified: > head/sys/dev/ce/ceddk.c > > Modified: head/sys/dev/ce/ceddk.c > ============================================================================== > --- head/sys/dev/ce/ceddk.c Thu Feb 23 15:10:46 2017 > (r314141) > +++ head/sys/dev/ce/ceddk.c Thu Feb 23 15:30:21 2017 > (r314142) > @@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c) > "UserRequest (%s:%d)\n", > __FUNCTION__, __LINE__)); > return; > } > - req->Command = TAU32_Configure_Commit | > - TAU32_Tx_Stop | TAU32_Rx_Stop; > +// req->Command = TAU32_Configure_Commit | > +// TAU32_Tx_Stop | TAU32_Rx_Stop; > > > Should probably stick to C-style comments, though. > They are valid C99 comments but I understand what you mean, OTOH, the code block appears to be so broken, that it doesn't matter. Pedro. > -Ben