Date: Sat, 26 Aug 2017 09:49:18 -0300 From: "Danilo G. Baio" <dbaio@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r448747 - in head/mail: . smfsav smfsav-devel smfsav-devel/files Message-ID: <20170826124918.l734webrde3dhm5m@dx240.localdomain> In-Reply-To: <b954dca4-829b-edd9-57b3-7285ebd96306@FreeBSD.org> References: <201708260118.v7Q1IGxA078692@repo.freebsd.org> <b954dca4-829b-edd9-57b3-7285ebd96306@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--munqhfa72wm7twwb
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Aug 26, 2017 at 10:27:21AM +0200, Mathieu Arnold wrote:
> Le 26/08/2017 =E0 03:18, Danilo G. Baio a =E9crit=A0:
> > PLIST_SUB=3D SMFSAV_RUN_DIR=3D${SMFSAV_RUN_DIR}
> > SUB_FILES+=3D pkg-message
> > +SUB_LIST=3D ${PLIST_SUB}
>=20
> This is a very bad idea, it does not do what you think it does.
>=20
> $ make -V SUB_LIST
> SMFSAV_RUN_DIR=3D/var/run/smfs OSREL=3D11.1 PREFIX=3D%D LOCALBASE=3D/usr/=
local=A0
> RESETPREFIX=3D/usr/local PORTDOCS=3D"" PORTEXAMPLES=3D"" LIB32DIR=3Dlib
> DOCSDIR=3D"share/doc/smfsav"=A0 EXAMPLESDIR=3D"share/examples/smfsav"=A0
> DATADIR=3D"share/smfsav"=A0 WWWDIR=3D"www/smfsav"=A0 ETCDIR=3D"etc/smfsav"
> PREFIX=3D/usr/local LOCALBASE=3D/usr/local=A0 DATADIR=3D/usr/local/share/=
smfsav
> DOCSDIR=3D/usr/local/share/doc/smfsav
> EXAMPLESDIR=3D/usr/local/share/examples/smfsav=A0
> WWWDIR=3D/usr/local/www/smfsav ETCDIR=3D/usr/local/etc/smfsav
>=20
> Now, you have two instances of many variables in there, for example:
>=20
> $ make -V SUB_LIST:METCDIR*
> ETCDIR=3D"etc/smfsav" ETCDIR=3D/usr/local/etc/smfsav
>=20
>=20
> It is completely unsupported, and I am quite sure it would likely break
> very badly.
>=20
> A quick fix would be to change =3D by :=3D, but :=3D sometime does other
> things that you do not expect. It would probably be better to dupplicate
> the content.
>=20
>=20
> --=20
> Mathieu Arnold
>=20
>=20
Fixed in r448767.
Thank you.
--=20
Danilo G. Baio (dbaio)
--munqhfa72wm7twwb
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEORj0UTsjzCy+enIkmpN7LfMuiNcFAlmhbkkACgkQmpN7LfMu
iNcNTA/+LN0LoOUZcZHVttpPmbn29e1UnyWWWulNxgJmEsStlTm5l4c2mODSY3q2
nRS6MxXEFc8LySALjb4EpRu6/SBF5XNWLjX3dubDVSD1LShia9wQtTM2zWRGWLOa
mnmD2yYgd8imJNFScDSlVdLmkRmoqz2XPOUh9vCapbayiuIPEIOvHAb1ZrUG/YIu
mgRQ/YXd7rpF65t8ISOCLwGUU366VxHRVsyb/nO6TrqqFqTL/d+d4cQL5/wDZNj3
c1YaNhwTwsa1ooaHM7t39PJKGfCqt3yM4Vm7uYvOVqKcA9BSxKu/AIOolqJiI9Og
dhhojvK2kAfsneW3AmWiXEcygP65dgj6V+JSw9Gh37Le6Rq4j1g+3blqX8aZaQYg
O2x7b8NH0CWg94b31kA7f3Lzy79BwUtqBCgoNPE3449+5vFjUlhpSYl9+ovR89Gg
hnsXD9/A0aAF7hyucEVJQKmwVa+ocYyFAwP/R4y0CfueQ+ZT6JyrYxj2S5zKSdp2
JF/994CH/M/OfSozlJrUJCaejgoSa/+9lKCAVQ++HLk8Fs1EHamdUzyFvk6xLsEz
vgk24go1eK10ZFyptBcUVRHrGJLSynd1H3gu7r2iB7bF//Vut4ExWD3G8eHbVjNC
XtHx3BCVtFU3JLAVw0KgJsRjKejOH5nH5GRLpRHLs7FYrqzsMiQ=
=y8RQ
-----END PGP SIGNATURE-----
--munqhfa72wm7twwb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170826124918.l734webrde3dhm5m>