Date: Sun, 01 Oct 2006 01:51:45 +0900 From: Hajimu UMEMOTO <ume@FreeBSD.org> To: John Hay <jhay@meraka.org.za> Cc: John Hay <jhay@FreeBSD.org>, src-committers@FreeBSD.org, Hajimu UMEMOTO <ume@FreeBSD.org>, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 nd6.c Message-ID: <ygeven51en2.wl%ume@mahoroba.org> In-Reply-To: <20060930162039.GA59699@zibbi.meraka.csir.co.za> References: <200609301408.k8UE8vpM069161@repoman.freebsd.org> <ygewt7l1l1c.wl%ume@mahoroba.org> <20060930162039.GA59699@zibbi.meraka.csir.co.za>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
>>>>> On Sat, 30 Sep 2006 18:20:39 +0200
>>>>> John Hay <jhay@meraka.org.za> said:
jhay> On Sat, Sep 30, 2006 at 11:33:35PM +0900, Hajimu UMEMOTO wrote:
> jhay> FreeBSD src repository
>
> jhay> Modified files:
> jhay> sys/netinet6 nd6.c
> jhay> Log:
> jhay> My previous commit broke "route add -inet6 <network_addr> -interface gif0".
> jhay> Fix that by excluding point-to-point interfaces.
>
> > - } else if (req == RTM_ADD && SDL(gate)->sdl_alen == 0) {
> > + } else if (req == RTM_ADD && SDL(gate)->sdl_alen == 0 &&
> > + (ifp->if_flags & (IFF_POINTOPOINT | IFF_LOOPBACK)) == 0) {
> > ln->ln_state = ND6_LLINFO_INCOMPLETE;
>
> Umm, it seems still there is a problem. We are using -interface not
> only for point-to-point interface and loopback.
> I'm not sure but can we check `(rt->rt_flags & RTF_HOST) != 0', here?
jhay> That would work better yes. Is there a reason you feel unsure about it?
jhay> Or is it just a case of not having tested it?
Because, I was just unsure of your intention, and I'm not having
tested it.
Sincerely,
--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ygeven51en2.wl%ume>