From owner-svn-ports-all@FreeBSD.ORG  Fri Jan 16 01:44:35 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7BD02863;
 Fri, 16 Jan 2015 01:44:35 +0000 (UTC)
Received: from gw.catspoiler.org (cl-1657.chi-02.us.sixxs.net
 [IPv6:2001:4978:f:678::2])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id EF98DF96;
 Fri, 16 Jan 2015 01:44:34 +0000 (UTC)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
 by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id t0G1iN3d019873;
 Thu, 15 Jan 2015 17:44:27 -0800 (PST)
 (envelope-from truckman@FreeBSD.org)
Message-Id: <201501160144.t0G1iN3d019873@gw.catspoiler.org>
Date: Thu, 15 Jan 2015 17:44:23 -0800 (PST)
From: Don Lewis <truckman@FreeBSD.org>
Subject: Re: svn commit: r375853 - head/finance/gnucash
To: kwm@rainbow-runner.nl
In-Reply-To: <201501152313.t0FND4ds019398@gw.catspoiler.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
Cc: svn-ports-head@FreeBSD.org, kwm@FreeBSD.org, svn-ports-all@FreeBSD.org,
 ports-committers@FreeBSD.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Jan 2015 01:44:35 -0000

On 15 Jan, Don Lewis wrote:
> On 15 Jan, Koop Mast wrote:
>> 
>> On 31-12-2014 8:28, Don Lewis wrote:
>>> On 30 Dec, Koop Mast wrote:
>>>> Author: kwm
>>>> Date: Tue Dec 30 20:28:43 2014
>>>> New Revision: 375853
>>>> URL: https://svnweb.freebsd.org/changeset/ports/375853
>>>> QAT: https://qat.redports.org/buildarchive/r375853/
>>>>
>>>> Log:
>>>>    Fix the build on 9.x and 8.x after the update of webkit-gtk2.
>>>>
>>>> Modified:
>>>>    head/finance/gnucash/Makefile
>>>>
>>>> Modified: head/finance/gnucash/Makefile
>>>> ==============================================================================
>>>> --- head/finance/gnucash/Makefile	Tue Dec 30 20:13:46 2014	(r375852)
>>>> +++ head/finance/gnucash/Makefile	Tue Dec 30 20:28:43 2014	(r375853)
>>>> @@ -96,6 +96,11 @@ GLIB_SCHEMAS+=	org.gnucash.dialogs.impor
>>>>   GLIB_SCHEMAS+=	org.gnucash.dialogs.import.ofx.gschema.xml
>>>>   .endif
>>>>   
>>>> +# because webkit-gtk2 needs it
>>>> +.if ${OSVERSION} < 1000000
>>>> +USES+= compiler:c++11-lib
>>>> +.endif
>>>> +
>>> Why not just set this unconditionally.  It should be a no-op if clang is
>>> the base compiler, and should do the right thing on a FreeBSD 10 machine
>>> if someone has configured it to use legacy gcc as the base compiler.
>> 
>> Sorry for the long reply time. I wanted to make the difference between 
>> that the port itself needs c++11-lib or that it was forced upon it by 
>> another port.
> 
> The comment should suffice for that.  The webkit-gtk2 Makefile sets
> USE=compiler:c++11-lib unconditionally.  Doing the same here would make
> sure that the two ports stay in sync.

Also, testing ${OSVERSION} will do the wrong thing on a FreeBSD 10
system that is configured to use our old gcc as the base compiler.