Date: Fri, 18 Mar 2005 11:25:52 -0800 From: Nate Lawson <nate@root.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/cardbus cardbus.c src/sys/dev/pccard pccard.c src/sys/dev/pci pci.c src/sys/i386/i386 nexus.c src/sys/isa isa_common.c src/sys/kern subr_bus.c src/sys/sys bus.h Message-ID: <423B2B40.6080600@root.org> In-Reply-To: <20050318051958.3E89916A53A@hub.freebsd.org> References: <20050318051958.3E89916A53A@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh wrote: > imp 2005-03-18 05:19:50 UTC > > FreeBSD src repository > > Modified files: > sys/dev/cardbus cardbus.c > sys/dev/pccard pccard.c > sys/dev/pci pci.c > sys/i386/i386 nexus.c > sys/isa isa_common.c > sys/kern subr_bus.c > sys/sys bus.h > Log: > Use STAILQ in preference to SLIST for the resources. Insert new resources > last in the list rather than first. > > This makes the resouces print in the 4.x order rather than the 5.x order > (eg fdc0 at 0x3f0-0x3f5,0x3f7 is 4.x, but 0x3f7,0x3f0-0x3f5 is 5.x). This > also means that the pci code will once again print the resources in BAR > ascending order. > > Revision Changes Path > 1.52 +4 -4 src/sys/dev/cardbus/cardbus.c > 1.100 +1 -1 src/sys/dev/pccard/pccard.c > 1.282 +1 -1 src/sys/dev/pci/pci.c > 1.61 +1 -1 src/sys/i386/i386/nexus.c > 1.42 +5 -5 src/sys/isa/isa_common.c > 1.174 +7 -7 src/sys/kern/subr_bus.c > 1.67 +2 -2 src/sys/sys/bus.h Great change. One nit: the reverse order helped expose bugs in some resource allocation routines. It might be nice to have some DEBUG option that inserted it at the head. The backwards behavior actually triggered the bug you fixed in rman on various systems and might have lead us to it earlier if someone had run it down. (Thanks for fixing that too.) -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?423B2B40.6080600>