Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Sep 2000 09:31:40 +0930
From:      Greg Lehey <grog@lemis.com>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        John Baldwin <jhb@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/libkern arc4random.c
Message-ID:  <20000912093140.S19431@wantadilla.lemis.com>
In-Reply-To: <Pine.BSF.4.21.0009111848490.818-100000@besplex.bde.org>; from bde@zeta.org.au on Mon, Sep 11, 2000 at 07:10:20PM %2B1100
References:  <200009110551.WAA27304@freefall.freebsd.org> <Pine.BSF.4.21.0009111848490.818-100000@besplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, 11 September 2000 at 19:10:20 +1100, Bruce Evans wrote:
> On Sun, 10 Sep 2000, John Baldwin wrote:
>
>> jhb         2000/09/10 22:51:58 PDT
>>
>>   Modified files:
>>     sys/libkern          arc4random.c
>>   Log:
>>   Add #include's of sys/proc.h and sys/param.h to silence a warning.
>>
>>   Revision  Changes    Path
>>   1.5       +3 -1      src/sys/libkern/arc4random.c
>
> #include's shouldn't be added or unsorted to work around new
> misimplementations in headers.  (<sys/random.h> now has a gratuitous
> dependency on <sys/proc.h> because it doesn't forward-declare
> "struct proc".  <sys/ktr.h> has a not-so-gratuitous dependency on
> <sys/systm.h> because it calls snprintf().  We hacked around the
> corresponding problem for macros that call panic() by declaring
> panic() in the wrong place.)

What's the correct solution?

Greg
--
Finger grog@lemis.com for PGP public key
See complete headers for address and phone numbers


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000912093140.S19431>