From owner-cvs-all Mon Sep 11 17: 1:50 2000 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 092A037B422; Mon, 11 Sep 2000 17:01:44 -0700 (PDT) Received: (from grog@localhost) by wantadilla.lemis.com (8.11.0/8.9.3) id e8C01eC83166; Tue, 12 Sep 2000 09:31:40 +0930 (CST) (envelope-from grog) Date: Tue, 12 Sep 2000 09:31:40 +0930 From: Greg Lehey To: Bruce Evans Cc: John Baldwin , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/libkern arc4random.c Message-ID: <20000912093140.S19431@wantadilla.lemis.com> References: <200009110551.WAA27304@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: ; from bde@zeta.org.au on Mon, Sep 11, 2000 at 07:10:20PM +1100 Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Monday, 11 September 2000 at 19:10:20 +1100, Bruce Evans wrote: > On Sun, 10 Sep 2000, John Baldwin wrote: > >> jhb 2000/09/10 22:51:58 PDT >> >> Modified files: >> sys/libkern arc4random.c >> Log: >> Add #include's of sys/proc.h and sys/param.h to silence a warning. >> >> Revision Changes Path >> 1.5 +3 -1 src/sys/libkern/arc4random.c > > #include's shouldn't be added or unsorted to work around new > misimplementations in headers. ( now has a gratuitous > dependency on because it doesn't forward-declare > "struct proc". has a not-so-gratuitous dependency on > because it calls snprintf(). We hacked around the > corresponding problem for macros that call panic() by declaring > panic() in the wrong place.) What's the correct solution? Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message