Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Aug 2016 08:20:18 -0600
From:      Adam Weinberger <adamw@adamw.org>
To:        Bernard Spil <brnrd@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r420150 - in head/security/letskencrypt: . files
Message-ID:  <A6276C8A-FD16-4C8F-BCCC-5A9532A70804@adamw.org>
In-Reply-To: <201608122317.u7CNHx6M069763@repo.freebsd.org>
References:  <201608122317.u7CNHx6M069763@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> On 12 Aug, 2016, at 17:17, Bernard Spil <brnrd@freebsd.org> wrote:
>=20
> Author: brnrd
> Date: Fri Aug 12 23:17:58 2016
> New Revision: 420150
> URL: https://svnweb.freebsd.org/changeset/ports/420150
>=20
> Log:
>  security/letskencrypt: Allow configurable license agreement
>=20
>    - Backport upstream fixes for -a option (license agreement URL)
>    - Bump PORTREVISION

Hi Bernard,

I'm confused about what I'm supposed to do here.

It looks like the new license URL was added as default:

> Added: head/security/letskencrypt/files/patch-main.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/security/letskencrypt/files/patch-main.c	Fri Aug 12 =
23:17:58 2016	(r420150)
> @@ -0,0 +1,55 @@
> +=20
> ++#define AGREEMENT "https://letsencrypt.org" \
> ++		  "/documents/LE-SA-v1.1.1-August-1-2016.pdf"

... but the pkg-message change says that I have to add arguments to the =
invocation:

> Modified: head/security/letskencrypt/files/pkg-message.in
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/security/letskencrypt/files/pkg-message.in	Fri Aug 12 =
23:02:52 2016	(r420149)
> +++ head/security/letskencrypt/files/pkg-message.in	Fri Aug 12 =
23:17:58 2016	(r420150)
> @@ -1,4 +1,15 @@
>=20
> +LetsEncrypt's ACME servers have changed the LE license
> +agreement. To successfully run renewal you have to add
> +
> +  -a https://letsencrypt.org/documents/LE-SA-v1.1.1-August-1-2016.pdf
> +
> +to the command invocation.

The files/letskencrypt.sh.in doesn't contain that argument.

So is it set automatically? Do I need to alter my letskencrypt.sh, or is =
the pkg-message inaccurate?

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A6276C8A-FD16-4C8F-BCCC-5A9532A70804>