Date: Mon, 9 Nov 2015 18:01:49 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: =?utf-8?Q?Jos=C3=A9_P=C3=A9rez?= <fbl@aoek.com>, freebsd-current@freebsd.org Subject: Re: Failing buildword due to execution permission (with fix) Message-ID: <45AD4F5D-DABD-47ED-99FA-A40FFFF3CC7E@gmail.com> In-Reply-To: <564147FF.2050107@FreeBSD.org> References: <d2efef40a9e28bec03742c49ec5e4682@mail.yourbox.net> <233C431B-1675-4A55-A46E-B1B858056A09@gmail.com> <564136A0.4080406@FreeBSD.org> <5655EBD2-5EC5-425E-82B9-F7FF30312F02@gmail.com> <564147FF.2050107@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Nov 9, 2015, at 17:27, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>=20
>> On 11/9/2015 5:17 PM, Garrett Cooper wrote:
>>=20
>>> On Nov 9, 2015, at 16:13, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>>=20
>>=20
>> ...
>>=20
>>> If this is a shell file then it is best to invoke it with 'sh' rather
>>> than a chmod/#!. The src checkout should be noexec-safe.
>>=20
>> Right. I think it'd be a good idea for me to hunt down other issues thoug=
h in the build by setting -o noexec.
>>=20
>>=20
>> The only thing that concerns me with doing that is that it could result i=
n weirdness, e.g. The osreldate.h generation script in include/ .
>=20
> It prepends 'sh'.
>=20
> include/Makefile:MK_OSRELDATE_SH=3D ${.CURDIR}/mk-osreldate.sh
> include/Makefile: sh ${MK_OSRELDATE_SH}
Yeah... I forgot.
I wrote up that patch at iX, and it was iterated over a bit. I was just reme=
mbering what happens when you use ${SHELL} (hint: no bueno if your build is k=
icked off with a csh/non-POSIX sh..).
I'll do that soon-ish.
Thanks!
-NGie=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45AD4F5D-DABD-47ED-99FA-A40FFFF3CC7E>