Date: Wed, 1 Jan 1997 15:36:27 +0100 (MET) From: Luigi Rizzo <luigi@labinfo.iet.unipi.it> To: phk@critter.dk.tfs.com Cc: freebsd-bugs@freefall.freebsd.org Subject: Re: bin/2347: sysinstall: ppp: recursive call in malloc() Message-ID: <199701011436.PAA00270@labinfo.iet.unipi.it> In-Reply-To: <199701011000.CAA21981@freefall.freebsd.org> from "Poul-Henning Kamp" at Jan 1, 97 01:59:43 am
next in thread | previous in thread | raw e-mail | index | archive | help
> >When installing via PPP I got the message on vty2 (the PPP screen anyway): > >ppp in malloc(): warning: recursive call. > > Alternatively any program like ppp that uses SIGALRM for a state machine > is severely limited in its implementation. I am using ppp here (basically 2.1R + phkmalloc) without the above problem. On passing, iijppp is extremely bad since it does a couple of malloc()/free() per packet (one for the header, one for the packet itself). On a 14.4 modem this amounts to at least 10 malloc/free per second, think what this means on a modem server. This could be easily fixed, if someone wants to look at it (I am afraid bu I don't have the time to work on this, but some of the people who added NAT might be relatively familiar with iijppp code). The code is relatively well structured and distinguishes between different classes of objects, so handling free lists withih iijppp for each class should be highly efficient. Luigi -----------------------------+-------------------------------------- Luigi Rizzo | Dip. di Ingegneria dell'Informazione email: luigi@iet.unipi.it | Universita' di Pisa tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy) fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/ _____________________________|______________________________________
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701011436.PAA00270>