Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Sep 2010 09:56:25 -0400 (EDT)
From:      Greg Larkin <glarkin@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        maho@FreeBSD.org
Subject:   ports/150918: [PATCH] math/blas: Prevent install of profiled lib when PROFILE option is unselected
Message-ID:  <201009241356.o8ODuPQk015666@fbsd70.entropy.prv>
Resent-Message-ID: <201009241430.o8OEU1C4080817@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         150918
>Category:       ports
>Synopsis:       [PATCH] math/blas: Prevent install of profiled lib when PROFILE option is unselected
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 24 14:30:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Greg Larkin
>Release:        FreeBSD 7.0-RELEASE i386
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD fbsd70.entropy.prv 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59:52 UTC 2008
>Description:
bsd.lib.mk checks the value of NO_PROFILE, not WITHOUT_PROFILE, to
determine if a profiled library should be built or not.  If WITH_PROFILE
is not defined, add NO_PROFILE to MAKE_ENV instead of WITHOUT_PROFILE.

This problem exhibits on 6.x, and the fix works on all versions of the OS.
Here is a relevant error log:
http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/e.6.20100921081508/blas-1.0_6.log

Port maintainer (maho@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- blas-1.0_6.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/math/blas/Makefile,v
retrieving revision 1.48
diff -u -u -r1.48 Makefile
--- Makefile	19 Sep 2010 22:23:22 -0000	1.48
+++ Makefile	24 Sep 2010 13:48:54 -0000
@@ -36,7 +36,7 @@
 MAKE_ENV+=	${_u}="${LOCALBASE}/bin/${_u:L}"
 .endfor
 
-OPTIONS=	"PROFILE" "Build and install a profiling library" Off
+OPTIONS=	PROFILE "Build and install a profiling library" Off
 
 .include <bsd.port.options.mk>
 
@@ -50,7 +50,7 @@
 .endif
 PLIST_FILES+=	lib/libblas_p.a
 .else
-MAKE_ENV+=	WITHOUT_PROFILE=
+MAKE_ENV+=	NO_PROFILE=
 .endif
 
 post-patch:
--- blas-1.0_6.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009241356.o8ODuPQk015666>