From owner-svn-ports-head@freebsd.org Wed Jan 4 22:18:22 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69369C9F05E; Wed, 4 Jan 2017 22:18:22 +0000 (UTC) (envelope-from feld@FreeBSD.org) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 40F0912FD; Wed, 4 Jan 2017 22:18:22 +0000 (UTC) (envelope-from feld@FreeBSD.org) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E5D9A20A8F; Wed, 4 Jan 2017 17:18:20 -0500 (EST) Received: from web3 ([10.202.2.213]) by compute3.internal (MEProxy); Wed, 04 Jan 2017 17:18:20 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=smtpout; bh=Cj HDh4Qi/utOnC14Ay3PN/iK8WI=; b=eDEpiDSAXnT1IKmCh+J/L+H5BUQaKY5za9 VpFB6K/B2Tk1cjfGyBzbZzl6sfUpJJsPpi/3t4BQFXbZy3vKAiWxDz0rs1cqLELb NjpcgukwANAwWhpIYncxkdUCSUGBc43vZtExaERmLaPNHTR870542Hlsraqvt2h0 5/HbSPMo4= X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id C4C4E9EE25; Wed, 4 Jan 2017 17:18:20 -0500 (EST) Message-Id: <1483568300.3959813.837597441.418E927F@webmail.messagingengine.com> From: Mark Felder To: Mathieu Arnold , "Sunpoet Po-Chuan Hsieh" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-8d3535ca Subject: Re: svn commit: r430581 - head/dns/dnscrypt-proxy Date: Wed, 04 Jan 2017 16:18:20 -0600 In-Reply-To: References: <201701041738.v04HcdNM006335@repo.freebsd.org> X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 22:18:22 -0000 On Wed, Jan 4, 2017, at 16:13, Mathieu Arnold wrote: > Le 04/01/2017 =C3=A0 19:21, Sunpoet Po-Chuan Hsieh a =C3=A9crit : > > > > +USE_LDCONFIG=3D yes > > + > > > > > > Hello Mark, > > > > This line seems to be incorrect. > > > > from /usr/ports/Mk/bsd.port.mk : > > # USE_LDCONFIG - If set to "yes", this adds ${PREFIX}/lib to the list = of > > # directories to be searched for > > shared libraries. > > # Otherwise, this is a list of > > directories to be added to that > > # list. The directory names are written= to > > #=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20 > > ${LOCALBASE}/libdata/ldconfig/${PKGBASE} which is then > > # used by the ldconfig startup script. > > > > USE_LDCONFIG is only needed when PLUGINS is enabled. > > Besides, PLUGINS installs shared objects to PREFIX/lib/dnscrypt-proxy. > > I think the correct one is: > > PLUGINS_USE=3DLDCONFIG=3D${PREFIX}/lib/dnscrypt-proxy > > >=20 > In any case, I don't think USE_LDCONFIG is needed here, the software > will know where to load its plugins from. >=20 Funny, right as I was finish testing and committing his suggested changes you make this point... --=20 Mark Felder ports-secteam & portmgr member feld@FreeBSD.org