Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Apr 2016 15:25:06 -0700
From:      John Baldwin <jhb@freebsd.org>
To:        Warner Losh <imp@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r298026 - head/sys/cam/scsi
Message-ID:  <1915510.JYiahWoHr4@ralph.baldwin.cx>
In-Reply-To: <201604150309.u3F39wPb047755@repo.freebsd.org>
References:  <201604150309.u3F39wPb047755@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, April 15, 2016 03:09:58 AM Warner Losh wrote:
> Author: imp
> Date: Fri Apr 15 03:09:58 2016
> New Revision: 298026
> URL: https://svnweb.freebsd.org/changeset/base/298026
> 
> Log:
>   Use the new TUNABLE_INT64 to match the type of sbintime_t.

This seems odd and possibly broken.  The tunable should accept the same
values in the same units as the sysctl (e.g. milliseconds here, not a
64-bit fixed-point sbintime_t).  Also, in HEAD if you just add
CTLFLAG_TUN you will get that for free I think (as the sysctl code in
HEAD will parse the integer from the tunable and pass it to your
SYSCTL_PROC handler during boot).

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1915510.JYiahWoHr4>