Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Jun 2006 10:26:42 GMT
From:      Paolo Pisati <piso@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 99595 for review
Message-ID:  <200606191026.k5JAQg8N049553@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=99595

Change 99595 by piso@piso_newluxor on 2006/06/19 10:26:28

	Anticipate ie->ie_handlers emptiness check

Affected files ...

.. //depot/projects/soc2006/intr_filter/sparc64/sparc64/intr_machdep.c#2 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/sparc64/sparc64/intr_machdep.c#2 (text+ko) ====

@@ -236,11 +236,11 @@
 	struct intr_vector *iv;
 	struct intr_event *ie;
 	struct intr_handler *ih;
-	int error, thread;
+	int error = 0, thread;
 
 	iv = cookie;
 	ie = iv->iv_event;
-	if (ie == NULL) {
+	if (ie == NULL || TAILQ_EMPTY(&ie->ie_handlers)) {
 		intr_stray_vector(iv);
 		return;
 	}
@@ -261,10 +261,7 @@
 	/* Schedule a heavyweight interrupt process. */
 	if (thread)
 		error = intr_event_schedule_thread(ie);
-	else if (TAILQ_EMPTY(&ie->ie_handlers))
-		error = EINVAL;
-	else
-		error = 0;
+
 	if (error == EINVAL)
 		intr_stray_vector(iv);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200606191026.k5JAQg8N049553>