From owner-p4-projects@FreeBSD.ORG  Mon Jun 19 10:26:43 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0BAD616A47A; Mon, 19 Jun 2006 10:26:43 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C07F216A479
	for <perforce@freebsd.org>; Mon, 19 Jun 2006 10:26:42 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9125643D48
	for <perforce@freebsd.org>; Mon, 19 Jun 2006 10:26:42 +0000 (GMT)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k5JAQg9L049556
	for <perforce@freebsd.org>; Mon, 19 Jun 2006 10:26:42 GMT
	(envelope-from piso@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k5JAQg8N049553
	for perforce@freebsd.org; Mon, 19 Jun 2006 10:26:42 GMT
	(envelope-from piso@freebsd.org)
Date: Mon, 19 Jun 2006 10:26:42 GMT
Message-Id: <200606191026.k5JAQg8N049553@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	piso@freebsd.org using -f
From: Paolo Pisati <piso@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 99595 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jun 2006 10:26:43 -0000

http://perforce.freebsd.org/chv.cgi?CH=99595

Change 99595 by piso@piso_newluxor on 2006/06/19 10:26:28

	Anticipate ie->ie_handlers emptiness check

Affected files ...

.. //depot/projects/soc2006/intr_filter/sparc64/sparc64/intr_machdep.c#2 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/sparc64/sparc64/intr_machdep.c#2 (text+ko) ====

@@ -236,11 +236,11 @@
 	struct intr_vector *iv;
 	struct intr_event *ie;
 	struct intr_handler *ih;
-	int error, thread;
+	int error = 0, thread;
 
 	iv = cookie;
 	ie = iv->iv_event;
-	if (ie == NULL) {
+	if (ie == NULL || TAILQ_EMPTY(&ie->ie_handlers)) {
 		intr_stray_vector(iv);
 		return;
 	}
@@ -261,10 +261,7 @@
 	/* Schedule a heavyweight interrupt process. */
 	if (thread)
 		error = intr_event_schedule_thread(ie);
-	else if (TAILQ_EMPTY(&ie->ie_handlers))
-		error = EINVAL;
-	else
-		error = 0;
+
 	if (error == EINVAL)
 		intr_stray_vector(iv);
 }