Date: Mon, 24 Sep 2001 19:53:37 +0200 From: Andrea Campi <andrea@webcom.it> To: David O'Brien <obrien@freebsd.org> Cc: Hajimu UMEMOTO <ume@mahoroba.org>, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc rc Message-ID: <20010924195337.A22199@webcom.it> In-Reply-To: <20010924103456.C9322@dragon.nuxi.com>; from obrien@freebsd.org on Mon, Sep 24, 2001 at 10:34:56AM -0700 References: <200109240303.f8O33qB64939@freefall.freebsd.org> <20010924175857.A21878@webcom.it> <20010925.015110.21914758.ume@mahoroba.org> <20010924192019.A22181@webcom.it> <20010924103456.C9322@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 24, 2001 at 10:34:56AM -0700, David O'Brien wrote:
> On Mon, Sep 24, 2001 at 07:20:19PM +0200, Andrea Campi wrote:
> > I am not opposing this patch, just asking for the reasoning behind it, warning
> > that it may break POLA, and asking for at least an UPDATING entry and/or no
> > MFC.
>
> For me it was a POLA that after I did ``vi /usr/local/etc/rc.d/foo.sh''
> the script barfed with "Bad interpreter" on the next reboot. It took me a
> while to realize what in the world was wrong. /etc/rc uses `sh' to run
> ${diskless_mount}, /etc/rc.devfs, and /etc/rc.local (which
> /usr/local/etc/rc.d/ is the 2nd generation of).
Very good reason indeed, and now I am fully convinced of the goodness of your
change. Still, since this has been this way since:
Revision 1.70 / (download) - annotate - [select for diffs], Mon Sep 18 07:38:18
1995 UTC (6 years ago) by jkh
Branch: MAIN
Changes since 1.69: +8 -4 lines
Diff to previous 1.69 (colored)
Add support for /etc/rc.local.d directory, ala SYSV. If the purists
don't like it, they don't have to use it. The check makes sure that
/etc/rc.local.d exists before attempting to do anything with it. Now
packages will be able to add their startups as /etc/rc.local.d/<pkgname>.sh
in order to get local startup behavior. Maybe we can stop adding
knobs to /etc/sysconfig for ports/packages now?
Submitted by: wollman & jkh
I think a lot of people might be used to this misbehavior. While I now know
about this, and will know to mv my startup scripts, a lot of people might be
bitten. Consider that the last time I disabled sometihng, it was a Linux
binary which reliably panic'd my laptop at startup...
So I still think this change grants an UPDATING entry, but will now shut up
whether this happens or not ;-)
> Also note that explicitly /usr/local/etc/rc.d/*.sh is run, not `*', but
> `*.sh'. This is so that you can move scripts out of the way. The fact
> that `chmod -x' worked, was just an unforeseen side affect.
Yes I know, and I read the diff to check this was still the case.
Andrea
>
> --
> -- David (obrien@FreeBSD.org)
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010924195337.A22199>