From owner-cvs-src@FreeBSD.ORG Sun Oct 30 10:03:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA0A216A41F; Sun, 30 Oct 2005 10:03:12 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F7D943D49; Sun, 30 Oct 2005 10:03:12 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9UA3B1G023502; Sun, 30 Oct 2005 10:03:11 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9UA3Bnt023501; Sun, 30 Oct 2005 10:03:11 GMT (envelope-from des) Message-Id: <200510301003.j9UA3Bnt023501@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Sun, 30 Oct 2005 10:03:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pcm dsp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Oct 2005 10:03:12 -0000 des 2005-10-30 10:03:11 UTC FreeBSD src repository Modified files: sys/dev/sound/pcm dsp.c Log: Add some safeguards to AIOSFMT: - Return EINVAL if play_format or rec_format is set but the corresponding sample rate is 0. - Don't try to set the playback or recording format to 0. Previously, issuing an AIOSFMT ioctl with an all-zeroes snd_chan_param would trigger a KASSERT in chn_fmtchain(); I'm unsure about the effects on a kernel without INVARIANTS. After this commit, issuing AIOSFMT with an all-zeroes snd_chan_param is equivalent to issuing AIOGFMT. MFC after: 2 weeks Revision Changes Path 1.86 +8 -2 src/sys/dev/sound/pcm/dsp.c