From owner-svn-src-all@freebsd.org Fri May 3 08:57:23 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0789615898E2; Fri, 3 May 2019 08:57:23 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C37818E9F6; Fri, 3 May 2019 08:57:16 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (mh0.gentlemail.de [78.138.80.135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id x438vDXt078377; Fri, 3 May 2019 10:57:13 +0200 (CEST) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id 450F23F6; Fri, 3 May 2019 10:57:13 +0200 (CEST) Subject: Re: svn commit: r346217 - in head/sys: fs/nfs fs/nfsclient kern sys To: Rick Macklem , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201904150127.x3F1RG7X062973@repo.freebsd.org> From: Harry Schmalzbauer Organization: OmniLAN Message-ID: <8a6cb225-8644-9949-09ab-7e1525e24034@omnilan.de> Date: Fri, 3 May 2019 10:57:12 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <201904150127.x3F1RG7X062973@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Greylist: ACL 130 matched, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [78.138.80.130]); Fri, 03 May 2019 10:57:13 +0200 (CEST) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: 78.138.80.135; Sender-helo: mh0.gentlemail.de; ) X-Rspamd-Queue-Id: C37818E9F6 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of freebsd@omnilan.de designates 2a00:e10:2800::a130 as permitted sender) smtp.mailfrom=freebsd@omnilan.de X-Spamd-Result: default: False [-6.74 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[omnilan.de]; TO_DN_SOME(0.00)[]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-3.51)[ip: (-9.19), ipnet: 2a00:e10:2800::/64(-4.67), asn: 25074(-3.68), country: DE(-0.01)]; MX_GOOD(-0.01)[mx0.gentlemail.de]; NEURAL_HAM_SHORT(-0.92)[-0.923,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25074, ipnet:2a00:e10:2800::/64, country:DE]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 08:57:23 -0000 Am 15.04.2019 um 03:27 schrieb Rick Macklem: > Author: rmacklem > Date: Mon Apr 15 01:27:15 2019 > New Revision: 346217 > URL: https://svnweb.freebsd.org/changeset/base/346217 > > Log: > Fix the NFSv4 client to safely find processes. > > r340744 broke the NFSv4 client, because it replaced pfind_locked() with a > call to pfind(), since pfind() acquires the sx lock for the pid hash and > the NFSv4 already holds a mutex when it does the call. > The patch fixes the problem by recreating a pfind_any_locked() and adding the > functions pidhash_slockall() and pidhash_sunlockall to acquire/release > all of the pid hash locks. > These functions are then used by the NFSv4 client instead of acquiring > the allproc_lock and calling pfind(). > > Reviewed by: kib, mjg > MFC after: 2 weeks Hello, I guess as long as r340744 isn't MFCd, this commit isn't needed in /stable/, is it? Any plans to MFC https://svnweb.freebsd.org/base?view=revision&revision=340744 (proc: convert pfind & friends to use pidhash locks and other cleanup) Thanks, -Harry