Date: Wed, 16 Oct 2002 10:03:34 -0700 From: Terry Lambert <tlambert2@mindspring.com> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Bruce Evans <bde@zeta.org.au>, net@freebsd.org, arch@freebsd.org Subject: Re: cvs commit: src/sys/dev/kbd atkbdcreg.h Message-ID: <3DAD9BE6.530F8466@mindspring.com> References: <14910.1034771362@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp wrote: > In message <20021016221657.I5365-100000@gamplex.bde.org>, Bruce Evans writes: > >Ideally, header files wouldn't have any "variable sized structs" or > >anything else that depends on options. Core headers have to be much > >more careful about this because including an options header nested > >would break most modules and everything outside of the kernel (apart > >from the bug that modules and things outside of the kernel have no > >way to determine the correct value for the option). > > I agree. > > Suggestions for the best way of fixing "struct ipq" in ip_var.h > hereby solicited. Please use a union; things like diversion information result in other information not being used. It makes no sense to uniformly bloat all memory allocations for minority features, merely for the sake of uniformity. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3DAD9BE6.530F8466>