Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Apr 2018 18:50:43 -0700
From:      Eitan Adler <eadler@freebsd.org>
To:        Benjamin Kaduk <kaduk@mit.edu>
Cc:        doc-committers@freebsd.org, svn-doc-all@freebsd.org,  svn-doc-head@freebsd.org
Subject:   Re: svn commit: r51540 - head/en_US.ISO8859-1/books/handbook/virtualization
Message-ID:  <CAF6rxgnNdXjMSMK0%2Bnn15OLq_P6vF1JZ3jxxnv42UirSJ__Vqw@mail.gmail.com>
In-Reply-To: <20180409134723.GA89183@kduck.kaduk.org>
References:  <201804090800.w3980lsg065537@repo.freebsd.org> <20180409134723.GA89183@kduck.kaduk.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 9 April 2018 at 06:47, Benjamin Kaduk <kaduk@mit.edu> wrote:
> On Mon, Apr 09, 2018 at 08:00:47AM +0000, Eitan Adler wrote:
>> Author: eadler
>> Date: Mon Apr  9 08:00:47 2018
>> New Revision: 51540
>> URL: https://svnweb.freebsd.org/changeset/doc/51540
>>
>> Log:
>>   handbook: prefer use of kld_list over loader.conf
>>
>>   While these are not semantically identical, prefer using kld_list where
>>   possible.
>>
>> Modified:
>>   head/en_US.ISO8859-1/books/handbook/virtualization/chapter.xml
>>
>> Modified: head/en_US.ISO8859-1/books/handbook/virtualization/chapter.xml
>> ==============================================================================
>> --- head/en_US.ISO8859-1/books/handbook/virtualization/chapter.xml    Fri Apr  6 16:20:13 2018        (r51539)
>> +++ head/en_US.ISO8859-1/books/handbook/virtualization/chapter.xml    Mon Apr  9 08:00:47 2018        (r51540)
>> @@ -1353,19 +1353,11 @@ crw-------   1 root  wheel  0x1a1 Mar 17 12:19 othergu
>>       </step>
>>
>>       <step>
>> -       <title><filename>/boot/loader.conf</filename></title>
>> -
>> -       <programlisting>vmm_load="YES"
>> -nmdm_load="YES"
>> -if_bridge_load="YES"
>> -if_tap_load="YES"</programlisting>
>> -     </step>
>> -
>> -     <step>
>>         <title><filename>/etc/rc.conf</filename></title>
>>
>>         <programlisting>cloned_interfaces="<replaceable>bridge0</replaceable> <replaceable>tap0</replaceable>"
>> -ifconfig_bridge0="addm <replaceable>igb0</replaceable> addm <replaceable>tap0</replaceable>"</programlisting>
>> +ifconfig_bridge0="addm <replaceable>igb0</replaceable> addm <replaceable>tap0</replaceable>
>> +kld_list="if_tap vmm nmdm"</programlisting>
>
> Do we have a good way to indicate that the if_tap, vmm, and nmdm
> entries should be added to any existing kld_list stanza, if already
> present?  Just adding a new line would have the second assignment
> override the first, which seems likely to cause breakage.

True. It might be worthwhile to change this to kld_list="$kld_list
..." but that seems less idiomatic.

Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnNdXjMSMK0%2Bnn15OLq_P6vF1JZ3jxxnv42UirSJ__Vqw>