Date: Sat, 19 Oct 2002 16:40:02 -0700 (PDT) From: "Steven G. Kargl" <kargl@troutmask.apl.washington.edu> To: freebsd-ports@FreeBSD.org Subject: Re: ports/44287: Fix build of mail/xmail Message-ID: <200210192340.g9JNe2pU084351@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/44287; it has been noted by GNATS. From: "Steven G. Kargl" <kargl@troutmask.apl.washington.edu> To: Kris Kennaway <kris@obsecurity.org> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/44287: Fix build of mail/xmail Date: Sat, 19 Oct 2002 16:30:31 -0700 (PDT) Kris Kennaway said: > On Sat, Oct 19, 2002 at 03:32:25PM -0700, Steven G. Kargl wrote: > > > extern char noshare *sys_errlist[]; > > #else > > extern int errno; > > -extern int sys_nerr; > > -extern char *sys_errlist[]; > > #endif > > You should avoid defining errno as well - it doesn't currently cause > an error, but it's wrong. > > Instead of patching these out, you should conditionally compile them > in the !defined(__FreeBSD__) case. This will make the patch more > acceptable to be taken back by the upstream author. > Kris, Okay, I'll start removing "extern int errno" when I see it. As to the use of !defined(__FreeBSD__), I started with the current patch and simply fix it. Should I discard old patches in favor of !defined(__FreeBSD__)? -- Steve http://troutmask.apl.washington.edu/~kargl/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210192340.g9JNe2pU084351>