From owner-freebsd-ports@FreeBSD.ORG Wed Mar 25 01:50:36 2015 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A619E9C0 for ; Wed, 25 Mar 2015 01:50:36 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6A3CDBFF for ; Wed, 25 Mar 2015 01:50:36 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t2P1oaUn076225 for ; Wed, 25 Mar 2015 01:50:36 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t2P1oaRB076223 for ports@freebsd.org; Wed, 25 Mar 2015 01:50:36 GMT (envelope-from bdrewery) Received: (qmail 86663 invoked from network); 24 Mar 2015 20:50:29 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 24 Mar 2015 20:50:29 -0500 Message-ID: <55121468.2040308@FreeBSD.org> Date: Tue, 24 Mar 2015 20:50:32 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Julian Elischer , ports@freebsd.org Subject: Re: patch to bsd.ports.mk to support out-of-tree patches. References: <5510F71B.7030900@freebsd.org> <20150324113240.Horde._MOpnfwGcxQa7v8pi_ozUQ2@webmail.df.eu> In-Reply-To: <20150324113240.Horde._MOpnfwGcxQa7v8pi_ozUQ2@webmail.df.eu> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fjtKXxOqNKJRKJviPblFJxd2cbWbU1m7n" Cc: mva@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2015 01:50:36 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fjtKXxOqNKJRKJviPblFJxd2cbWbU1m7n Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/24/2015 5:32 AM, Marcus von Appen wrote: > Julian Elischer : >=20 > [...] >> esac | ${PATCH} ${PATCH_DIST_ARGS} `patch_dist_strip $$i` ; \= >> done ) >> .endif >> +.if defined(EXTRA_PATCH_TREE) > [...] >> +.endif >> .if defined(EXTRA_PATCHES) >> @set -e ; \ >> for i in ${EXTRA_PATCHES}; do \ >> >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > Nice. I'd however change the patch behaviour to the following: >=20 > - patch-* from FreeBSD > - EXTRA_PATCHES from FreeBSD > - local patches >=20 > Your patch looks like it appleis the out-of-tree patches prior > to any EXTRA_PATCHES defined by the port itself. This should not be > the case, in my opinion. Locally managed patches should always come > last to ensure that all FreeBSD/maintainer-specific bits have been > applied and the local changes are just added on top of those. >=20 > Cheers > Marcus >=20 Agreed. The local patches are intended to avoid touching the port. If they are not last then you may have to go tweaking some of the other ports patches to fix your own. --=20 Regards, Bryan Drewery --fjtKXxOqNKJRKJviPblFJxd2cbWbU1m7n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVEhRoAAoJEDXXcbtuRpfPBEgIAK8umMiyFNDvkYILtEP9jjLW uB7nOyI1ehBXnjaI22nEBKPLwWsWNtMZ4AXXPZGU4/nBBcRLRCoaZn7rzWUROBc6 EoqV7MNz17o54sIr+Rp/MHc3uB2X1yT3G89LYgU4dcSper/O0I8xvbTHWrQCizVb bkJ8DWB7mPfx5aLz1jKHEJZokffmH3TgLKjRh+aFdJaJCqlxVUBDv5z8nlxS1EqO wLei6sJ4H1eH5YTce9RKaUI+2WXT8WUrLNI4IWFDuMl6bYgnZIxmlIEtGn+kTF0p 3zZIQb/o+zObkIJ+2cz/U/zkQPF6EutTt1/ok05kVL373daSxYBGb7OHfx40FNQ= =YaEj -----END PGP SIGNATURE----- --fjtKXxOqNKJRKJviPblFJxd2cbWbU1m7n--