From owner-svn-ports-all@FreeBSD.ORG Thu May 14 16:09:04 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 682E298B for ; Thu, 14 May 2015 16:09:04 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 483A21EEE for ; Thu, 14 May 2015 16:09:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t4EG94Sq010178 for ; Thu, 14 May 2015 16:09:04 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t4EG94ns010172 for svn-ports-all@freebsd.org; Thu, 14 May 2015 16:09:04 GMT (envelope-from bdrewery) Received: (qmail 44703 invoked from network); 14 May 2015 11:09:02 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 14 May 2015 11:09:02 -0500 Message-ID: <5554C8A1.50200@FreeBSD.org> Date: Thu, 14 May 2015 11:09:05 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Adam Weinberger CC: "Philip M. Gollucci" , "ports-committers@freebsd.org" , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Subject: Re: svn commit: r386285 - head/security/keychain References: <201505140101.t4E11r9T031351@svn.freebsd.org> <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org> <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> <5554C761.3060609@FreeBSD.org> <07ED759D-DFAC-44D0-A22B-1639EE3E0CB8@adamw.org> In-Reply-To: <07ED759D-DFAC-44D0-A22B-1639EE3E0CB8@adamw.org> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="D2aSPSvI60Jco2eOa84ksB1MQuQ9qwPNo" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2015 16:09:04 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --D2aSPSvI60Jco2eOa84ksB1MQuQ9qwPNo Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 5/14/2015 11:07 AM, Adam Weinberger wrote: >> On 14 May, 2015, at 10:03, Bryan Drewery wrote:= >> >> On 5/14/2015 11:00 AM, Adam Weinberger wrote: >>>> On 13 May, 2015, at 21:20, Philip M. Gollucci = wrote: >>>> >>>> Then it needs an option not an if exists() >>> >>> Bryan, can you please consider reverting it, or giving me approval to= revert it? It may fix the case when the port is built in poudriere witho= ut sshd in base, but it is a regression for everybody else. >>> >>> # Adam >>> >>> >> >> No. The way RUN_DEPENDS is supposed to work is what I said in the >> commit. These exists() checks are redundant and confuse the package >> dependencies. >> >> How are you building? It's possible the tool you are using is >> incorrectly handling RUN_DEPENDS. >=20 > Ah! I see. It's portmaster that's doing the misbehaving. The problem is= that openssh-portable still shows up in run-depends-list, and so portmas= ter decides that it is going to install openssh-portable first. >=20 > [root@apnoea /usr/ports/security/keychain] which ssh-agent > /usr/bin/ssh-agent > [root@apnoea /usr/ports/security/keychain] make run-depends-list > /usr/ports/security/openssh-portable > /usr/ports/shells/bash >=20 Ok. I'll look at portmaster and try to fix it now. We really need these exists() to go away; it causes rebuilds on the package cluster for no reason. This specific case is not one, but we need them to generally go away. --=20 Regards, Bryan Drewery --D2aSPSvI60Jco2eOa84ksB1MQuQ9qwPNo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVVMihAAoJEDXXcbtuRpfPu4oH/2aRqXNdJriYSsxBFrR5GCaY vbetE8wlZa5ntFCg+1jt7cWawLRwz6yihqXnBXLv9e/C2jOzR1pscOcbDMmxyZfu GUHE9oytZcJMMUC1jC9j1/+sr7Pa93BT5+EWR1N3371jIcbW91DPVs/gXxpJBjZL mjG7TZ7x6YMldDC9sZCK0pFo/vJlPp1mn4iZvrlkVO+v74tO8KK24KaviPOscn6+ LnGJJ4j3ipC4fCTzUZFdm+WFPB7ob6DrhZj7+ErBKGVD5iT06xpfD4Ans9jLiWDZ EHwxvbPWO5AubjleYxP+PTqPxGNrVpWGNq/IKl9Nh7ePShUbM32sFaDgqsQfp8o= =FiFN -----END PGP SIGNATURE----- --D2aSPSvI60Jco2eOa84ksB1MQuQ9qwPNo--