From owner-svn-ports-all@FreeBSD.ORG Thu Mar 14 15:30:08 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 266946C9 for ; Thu, 14 Mar 2013 15:30:08 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-ve0-f175.google.com (mail-ve0-f175.google.com [209.85.128.175]) by mx1.freebsd.org (Postfix) with ESMTP id DB8AE6E5 for ; Thu, 14 Mar 2013 15:30:07 +0000 (UTC) Received: by mail-ve0-f175.google.com with SMTP id cy12so1809426veb.34 for ; Thu, 14 Mar 2013 08:30:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=UXyZQZeUNY7q0yZiuM4OkHYcBjQ9yQWlIkgUyZW25a0=; b=Gm51NYGlpThwKz/TJ4bhJ3uRLadp68YriCEgyaAkIWyhK5D+h7CFGL4EPLRVl7Kgs/ /ari25a32Fg3GLky/71fV8Q45WvdFoNC37K5Krlmi8EV9JUimQZ8uzKUqxGugMWcQZG4 nvDbh/5TKwEnRefxupPnX2h1bZrQ5K+/WyjNxKR+HOwlZBYuLmpJy3uTrCMKLHTBCaYu 2U7Oe/10FurWzy99kSnP2fvAQmwkmE3O5JgK1DLjrHVzzDRFHJI9s6dUulJt1GHJ46Mo wuB78Qd7rk4L9n6V8djYqgb4WNTI9Ic4soUEeYXvudFR0/c5bkD4WJoVu2AOgF4O6DwM dUTA== MIME-Version: 1.0 X-Received: by 10.58.80.4 with SMTP id n4mr2249661vex.5.1363275006964; Thu, 14 Mar 2013 08:30:06 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.58.30.79 with HTTP; Thu, 14 Mar 2013 08:30:06 -0700 (PDT) In-Reply-To: <20130314081701.GA6014@FreeBSD.org> References: <201303132159.r2DLx1QL092713@svn.freebsd.org> <20130314070455.GA42406@hatter> <20130314075330.GA94901@FreeBSD.org> <201303132359.22984.beech@freebsd.org> <20130314081701.GA6014@FreeBSD.org> Date: Thu, 14 Mar 2013 08:30:06 -0700 X-Google-Sender-Auth: 2GGPUv33cmJZLO9QlqmPlFtCyq0 Message-ID: Subject: Re: svn commit: r314117 - head/games/kye From: Jason Helfman To: Alexey Dokuchaev X-Gm-Message-State: ALoCoQnyVCdeMDs0EtkFetyAMFEYrSJpjW1CbTw6nTdgyEfoLQ0lWI3iq1nUEBn4tlzi+Nw8vtKq Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Beech Rintoul , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2013 15:30:08 -0000 On Thu, Mar 14, 2013 at 1:17 AM, Alexey Dokuchaev wrote: > On Wed, Mar 13, 2013 at 11:59:22PM -0800, Beech Rintoul wrote: > > On Wednesday 13 March 2013 23:53:30 Alexey Dokuchaev wrote: > > > I think that tindy will complain about nonexistent files upon package > > > deletion. > > > > > > > as this is a PLIST_SUB, and it will translate to: > > > > > > > > share/doc/kye/NEWS > > > > share/doc/kye/README > > > > > > Correct. That means, it now duplicates PORTDOCS set in the Makefile. > > > > This did not fail either on my tindy or on redports > > Hmm, did you use -plistcheck switch when running ./tc? 'cause it should, > per this quick test: > > $ make generate-plist add-plist-docs > $ grep doc /tmp/usr/ports/games/kye/work/.PLIST.mktmp > share/doc/kye/NEWS > share/doc/kye/README > @dirrm share/doc/kye > share/doc/kye/NEWS > share/doc/kye/README > @dirrm share/doc/kye > > ./danfe > > PORTDOCS make variable assignment is different then a PLIST_SUB. It also depends how it is used in the Makefile. In this instance, they are both used correctly. -jgh