Date: Fri, 20 Mar 2015 13:47:16 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org>, Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381760 - in head/x11-fonts/sourcesanspro-ttf: . files Message-ID: <550C6B34.8020401@FreeBSD.org> In-Reply-To: <9BE33FCA-5C2F-4FEA-9B3A-5D9DB6632635@adamw.org> References: <201503201823.t2KIN32I080448@svn.freebsd.org> <550C6655.5010802@FreeBSD.org> <20150320183524.GD87678@ivaldir.etoilebsd.net> <9BE33FCA-5C2F-4FEA-9B3A-5D9DB6632635@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--T4jifqHcmJOFo8SwqjAI3MCLo8mN7Vmo1
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 3/20/2015 1:43 PM, Adam Weinberger wrote:
>=20
>> On 20 Mar, 2015, at 12:35, Baptiste Daroussin <bapt@FreeBSD.org> wrote=
:
>>
>> On Fri, Mar 20, 2015 at 01:26:29PM -0500, Bryan Drewery wrote:
>>> On 3/20/2015 1:23 PM, Baptiste Daroussin wrote:
>>>> +WRKSRC=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME:S,/,-,}
>>>
>>> I think we should put this globally in this 1 line:
>>>
>>> bsd.port.mk
>>> 1561 . if defined(GH_TAGNAME)
>>> 1562 WRKSRC?=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME}
>>>
>>>
>>> After https://reviews.freebsd.org/D2103 is resolved I will fix that.
>>
>> Almost in this case upstream decided to put a / in the TAGNAME which i=
s ... well
>> ... :)
>=20
> It would be so unbelievably nice if we had a way to just specify the de=
stination filename, using fetch -o. All the bizarre names that files are =
published as, the unversioned tarballs, the documentation files labelled =
Documentation.pdf, and the fallout from changes like this.... we could ma=
ke our lives so much easier with a DISTFILE_DEST variable.
>=20
> # Adam
>=20
>=20
For USE_GITHUB that is exactly what DISTNAME is. You can name it
whatever you want.
As for your other examples I agree. I'll look into that!
--=20
Regards,
Bryan Drewery
--T4jifqHcmJOFo8SwqjAI3MCLo8mN7Vmo1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJVDGs1AAoJEDXXcbtuRpfPq0gH/29wpX436QX5k9VRIX/gzg9o
OBMKgyUdzeF2Zeh2R1bPCBCN4c/JgvL4Rxf50EwVm+LARXjImCRH0nm14J5iva5R
2HDJKMPbiGtKPM44SIXgMhNfRm0pw1g5bgSrb441KU1VuW8+SVYJftbwC2l4TNd0
pVYT92HLN9/7mOa+C4dl5t8M7Ys9vVCkUcOkIQh0z2CHYeGovepkGnewU+mhvu4A
0Wru1iuAL1MTjRO4vakG7dcq+kUXDxBlhiXvVSLBzj3Jzt1Nf6aQF7tNpDyMyELn
vP31gZPmKcr046zJnhsrmsik9536ez34EXO2z2dSXgStgwdD1l1wRr7F989tZ+M=
=YY/3
-----END PGP SIGNATURE-----
--T4jifqHcmJOFo8SwqjAI3MCLo8mN7Vmo1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?550C6B34.8020401>