From owner-cvs-src@FreeBSD.ORG Mon Aug 18 12:22:00 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8446837B408; Mon, 18 Aug 2003 12:22:00 -0700 (PDT) Received: from mail.broadpark.no (mail.broadpark.no [217.13.4.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id B6B9E43FB1; Mon, 18 Aug 2003 12:21:56 -0700 (PDT) (envelope-from des@des.no) Received: from smtp.des.no (37.80-203-228.nextgentel.com [80.203.228.37]) by mail.broadpark.no (Postfix) with ESMTP id AED6479283; Mon, 18 Aug 2003 21:21:55 +0200 (MEST) Received: by smtp.des.no (Pony Express, from userid 666) id 561F09643F; Mon, 18 Aug 2003 21:21:55 +0200 (CEST) Received: from dwp.des.no (dwp.des.no [10.0.0.4]) by smtp.des.no (Pony Express) with ESMTP id 3AD469643E; Mon, 18 Aug 2003 21:21:51 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 02FEDB824; Mon, 18 Aug 2003 21:21:50 +0200 (CEST) To: John Baldwin References: <200308181802.h7II2XGZ013601@repoman.freebsd.org> From: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) Date: Mon, 18 Aug 2003 21:21:50 +0200 In-Reply-To: <200308181802.h7II2XGZ013601@repoman.freebsd.org> (John Baldwin's message of "Mon, 18 Aug 2003 11:02:33 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.090024 (Oort Gnus v0.24) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, hits=-3.0 required=8.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES,USER_AGENT_GNUS_UA version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/pseudofs pseudofs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Aug 2003 19:22:01 -0000 John Baldwin writes: > Log: > The allproc lock is a sx lock, not a mutex, so fix the assertion. This > asserts that the sx lock is held, but does not specify if the lock is h= eld > shared or exclusive, thus either type of lock satisfies the assertion. My bad - but why didn't I get a warning about the incorrect pointer type? And why did the code run fine with INVARIANT_SUPPORT and INVARIANTS defined? Just lucky? DES --=20 Dag-Erling Sm=F8rgrav - des@des.no