Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Apr 2010 08:45:55 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r206546 - head/sys/kern
Message-ID:  <201004130845.o3D8jt4n097467@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Tue Apr 13 08:45:55 2010
New Revision: 206546
URL: http://svn.freebsd.org/changeset/base/206546

Log:
  Remove XXX comment. Add another comment, describing why f_vnode assignment
  is useful.
  
  MFC after:	3 days

Modified:
  head/sys/kern/vfs_syscalls.c

Modified: head/sys/kern/vfs_syscalls.c
==============================================================================
--- head/sys/kern/vfs_syscalls.c	Tue Apr 13 06:48:37 2010	(r206545)
+++ head/sys/kern/vfs_syscalls.c	Tue Apr 13 08:45:55 2010	(r206546)
@@ -1124,7 +1124,12 @@ kern_openat(struct thread *td, int fd, c
 	NDFREE(&nd, NDF_ONLY_PNBUF);
 	vp = nd.ni_vp;
 
-	fp->f_vnode = vp;	/* XXX Does devfs need this? */
+	/*
+	 * Store the vnode, for any f_type. Typically, the vnode use
+	 * count is decremented by direct call to vn_closefile() for
+	 * files that switched type in the cdevsw fdopen() method.
+	 */
+	fp->f_vnode = vp;
 	/*
 	 * If the file wasn't claimed by devfs bind it to the normal
 	 * vnode operations here.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201004130845.o3D8jt4n097467>