Date: Thu, 14 Mar 2013 08:30:06 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Beech Rintoul <beech@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r314117 - head/games/kye Message-ID: <CAMuy=%2BhkQ%2BqieiwX97%2BC9jfAkGVOzrAwvh0cTeQ1Z1dYU0Scag@mail.gmail.com> In-Reply-To: <20130314081701.GA6014@FreeBSD.org> References: <201303132159.r2DLx1QL092713@svn.freebsd.org> <20130314070455.GA42406@hatter> <20130314075330.GA94901@FreeBSD.org> <201303132359.22984.beech@freebsd.org> <20130314081701.GA6014@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 14, 2013 at 1:17 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Wed, Mar 13, 2013 at 11:59:22PM -0800, Beech Rintoul wrote: > > On Wednesday 13 March 2013 23:53:30 Alexey Dokuchaev wrote: > > > I think that tindy will complain about nonexistent files upon package > > > deletion. > > > > > > > as this is a PLIST_SUB, and it will translate to: > > > > > > > > share/doc/kye/NEWS > > > > share/doc/kye/README > > > > > > Correct. That means, it now duplicates PORTDOCS set in the Makefile. > > > > This did not fail either on my tindy or on redports > > Hmm, did you use -plistcheck switch when running ./tc? 'cause it should, > per this quick test: > > $ make generate-plist add-plist-docs > $ grep doc /tmp/usr/ports/games/kye/work/.PLIST.mktmp > share/doc/kye/NEWS > share/doc/kye/README > @dirrm share/doc/kye > share/doc/kye/NEWS > share/doc/kye/README > @dirrm share/doc/kye > > ./danfe > > PORTDOCS make variable assignment is different then a PLIST_SUB. It also depends how it is used in the Makefile. In this instance, they are both used correctly. -jgh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMuy=%2BhkQ%2BqieiwX97%2BC9jfAkGVOzrAwvh0cTeQ1Z1dYU0Scag>