From owner-freebsd-fs@FreeBSD.ORG Mon Feb 7 09:17:03 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C6A6106566B for ; Mon, 7 Feb 2011 09:17:03 +0000 (UTC) (envelope-from l.pizzamiglio@bally-wulff.de) Received: from mail2.bally-wulff-berlin.de (mail2.bally-wulff-berlin.de [212.144.118.9]) by mx1.freebsd.org (Postfix) with ESMTP id 17B718FC1B for ; Mon, 7 Feb 2011 09:17:02 +0000 (UTC) Received: from bwex.bally-wulff.de (unknown [192.9.204.106]) by mail2.bally-wulff-berlin.de (Postfix) with ESMTP id C856999078; Mon, 7 Feb 2011 10:17:00 +0100 (CET) Received: from [192.9.205.177] ([192.9.205.177]) by bwex.bally-wulff.de with Microsoft SMTPSVC(6.0.3790.4675); Mon, 7 Feb 2011 10:17:01 +0100 Message-ID: <4D4FB88A.90906@bally-wulff.de> Date: Mon, 07 Feb 2011 10:16:58 +0100 From: Luca Pizzamiglio User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.13) Gecko/20101213 Thunderbird/3.1.7 MIME-Version: 1.0 To: Gleb Kurtsou References: <4D4BE50A.7000705@bally-wulff.de> <20110204141254.1dd98de8@ernst.jennejohn.org> <20110204224856.GA78229@tops.skynet.lt> <20110205100728.46f5ca92@ernst.jennejohn.org> <20110205211405.GA7212@tops.skynet.lt> In-Reply-To: <20110205211405.GA7212@tops.skynet.lt> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 07 Feb 2011 09:17:01.0260 (UTC) FILETIME=[C71D10C0:01CBC6A7] Cc: freebsd-fs@freebsd.org Subject: Re: building kernel including GEOM_VINUM X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2011 09:17:03 -0000 On 02/05/2011 22:14, Gleb Kurtsou wrote: > On (05/02/2011 10:07), Gary Jennejohn wrote: >> On Sat, 5 Feb 2011 00:48:56 +0200 >> Gleb Kurtsou wrote: >>> On (04/02/2011 14:12), Gary Jennejohn wrote: >>>> It would probably require some major hacking. Apparently gvinum was >>>> designed with using it only as a KLD in mind. >>> The change it trivial, just add files listed in >>> sys/modules/geom/geom_vinum/Makefile to sys/files. >>> It was also necessary it tweak /sbin/gvinum to check if module loaded >>> during startup to eliminate useless warning (afair). >> >> For someone not used to working with the kernel I'd say that what you >> describe is major hacking. Especially the modification to gvinum. > The patch attached. Would you test if it's ok in both cases: built-in > and module. vinum(4) man page states that loading it as module is > preferred, I see no reason for it to still remain so, the text was > written in ~1999 and vinum was rewritten on top of geom afterwards. Hi Gleb! thanks a lot for the patch!! I'll start to test it in both cases! The handbook doesn't contain an error, but it's inaccurate. The vinum(4) man page, instead, contains an error: the SYNOPSIS "device vinum" is wrong. I could open a PR to fix at least the man page and then Gleb could "officially" submit its patch (after tests). I'm impressed by the quality of FreeBSD and I'd love to contribute with my 5 cents... Thanks again! > > Thanks, > Gleb. Best regards, Luca Pizzamiglio