Date: Wed, 7 May 2014 07:47:21 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Luiz Otavio O Souza <lists.br@gmail.com> Cc: freebsd-embedded <freebsd-embedded@freebsd.org>, freebsd-geom@freebsd.org Subject: Re: [RFC] geom_uncompress(4) changes Message-ID: <A0B2C813-42C6-4803-9F76-554783FB37D6@xcllnt.net> In-Reply-To: <CAB=2f8w2KmtfBAnC83yUS0n%2B7jq4jM2-Ub_1%2BaMAW=QczqbPwA@mail.gmail.com> References: <CAB=2f8w2KmtfBAnC83yUS0n%2B7jq4jM2-Ub_1%2BaMAW=QczqbPwA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_77C82B65-197C-4B3C-981C-8512893D1E00 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Apr 29, 2014, at 4:50 AM, Luiz Otavio O Souza <lists.br@gmail.com> wrote: > Hi, > > I've the attached changes to geom_uncompress(4) that modularise the > compression support. > > It can now be built with support to mkuzip(8) or mkulzma(8) (or both) > independently. > > It also make a lot easier to add the support to new compression > methods on geom_uncompress. > > Now, building a kernel with 'options GEOM_UNCOMPRESS' (kept for > backward compatibility) adds only the support to read mkulzma images. You're not quite backward compatible, because GEOM_UNCOMPRESS now includes both lzma and zip. You may want to add GEOM_UNCOMPRESS_ULZMA and document it as the way to add support for lzma. That way you can simply "redefine" GEOM_UNCOMPRESS as meaning any and all compression algorithms. Thus: - GEOM_UNCOMPRESS gives you support for any and all. - GEOM_UNCOMPRESS_FOO gives you support for just FOO. > > I think we could eventually retire geom_uzip(8) as they are doing > essentially the same thing (with the same implementation and code...). > But this lets a lot of open questions regarding backward > compatibility. You can even redefine GEOM_UZIP to do what GEOM_UNCOMPRESS_UZIP does. If the code is effectively the same then compatibility is about the options, not the actual C files underneath... In general: good! -- Marcel Moolenaar marcel@xcllnt.net --Apple-Mail=_77C82B65-197C-4B3C-981C-8512893D1E00 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEUEARECAAYFAlNqR3kACgkQpgWlLWHuifaqAwCYwhmdAEdzD1X9lPFEmzg1BaXM HACeLqcmohEBBhRMNhmT2L8GMEqAOiQ= =J8Zq -----END PGP SIGNATURE----- --Apple-Mail=_77C82B65-197C-4B3C-981C-8512893D1E00--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A0B2C813-42C6-4803-9F76-554783FB37D6>