Date: Wed, 31 Jan 2007 00:48:18 GMT From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 113740 for review Message-ID: <200701310048.l0V0mIfc009066@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=113740 Change 113740 by rwatson@rwatson_peppercorn on 2007/01/31 00:47:31 Don't document the order the pointers are returned in by getzbuf. Affected files ... .. //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#5 edit Differences ... ==== //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#5 (text+ko) ==== @@ -421,7 +421,8 @@ * copied versions of those originally submitted via the setzbuf ioctl--if * user space has remapped the buffers, then they may be inconsistent. User * applications must be aware that these are in effect buffer names, not - * pointers, if they play such games with their address space. + * pointers, if they play such games with their address space. Pointers are + * returned in arbitrary order, which may vary by ioctl. */ int bpf_zerocopy_ioctl_getzbuf(struct thread *td, struct bpf_d *d, @@ -432,9 +433,6 @@ KASSERT(d->bd_bufmode == BPF_BUFMODE_ZBUF, ("bpf_zerocopy_ioctl_getzbuf: not in zbuf mode")); - /* - * Sort so that the next buffer to read is the 'a' buffer. - */ bzero(bz, sizeof(*bz)); BPFD_LOCK(d); if (d->bd_hbuf != NULL) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701310048.l0V0mIfc009066>