From owner-p4-projects@FreeBSD.ORG  Fri Jul  7 10:59:22 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 87D0816A4E5; Fri,  7 Jul 2006 10:59:22 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 477AE16A4DA
	for <perforce@FreeBSD.org>; Fri,  7 Jul 2006 10:59:22 +0000 (UTC)
	(envelope-from wkoszek@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0F0E543D49
	for <perforce@FreeBSD.org>; Fri,  7 Jul 2006 10:59:22 +0000 (GMT)
	(envelope-from wkoszek@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k67AxLqe089161
	for <perforce@FreeBSD.org>; Fri, 7 Jul 2006 10:59:21 GMT
	(envelope-from wkoszek@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k67AxLRG089157
	for perforce@freebsd.org; Fri, 7 Jul 2006 10:59:21 GMT
	(envelope-from wkoszek@FreeBSD.org)
Date: Fri, 7 Jul 2006 10:59:21 GMT
Message-Id: <200607071059.k67AxLRG089157@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	wkoszek@FreeBSD.org using -f
From: "Wojciech A. Koszek" <wkoszek@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 100859 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Jul 2006 10:59:22 -0000

http://perforce.freebsd.org/chv.cgi?CH=100859

Change 100859 by wkoszek@wkoszek_laptop on 2006/07/07 10:58:41

	Atomic operations here are like: block interrupts -> do operation ->
	unblock interrupts. Thus, I think double intr_disable() here is a
	mistake. Replace it with intr_restore().

Affected files ...

.. //depot/projects/mips2/src/sys/mips/include/atomic.h#3 edit

Differences ...

==== //depot/projects/mips2/src/sys/mips/include/atomic.h#3 (text+ko) ====

@@ -133,7 +133,14 @@
 	s = intr_disable();
 	result = *addr;
 	*addr = 0;
+	/*
+	 * XXXMIPS: I think it's a mistake. We should have intr_restore()
+	 * here, shouldn't we?
+	 */
+#if 0
 	intr_disable();
+#endif
+	intr_restore(s);
 	return (result);
 }