Date: Sun, 5 Nov 2017 08:30:20 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: "O. Hartmann" <ohartmann@walstatt.org>, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Cy Schubert <Cy.Schubert@komquats.com> Subject: Re: svn commit: r325404 - head/share/mk Message-ID: <0b1ad34d-bc2f-c0fb-5ed3-68d07f4a7aac@FreeBSD.org> In-Reply-To: <13707.1509899195@kaos.jnpr.net> References: <201711042102.vA4L2RuR063978@repo.freebsd.org> <20171104223133.00f5bf30@thor.intern.walstatt.dynvpn.de> <20171105111644.4c294342@thor.intern.walstatt.dynvpn.de> <7d0c021d-fe3d-9bea-b088-5e530176288b@FreeBSD.org> <13707.1509899195@kaos.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--QNokupXj5FohTNa4AmPgigvakF7NgGPWX
Content-Type: multipart/mixed; boundary="T9L9mboiQXoHsEmc0EVPFO9rBvo7FhW9h";
protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: "Simon J. Gerraty" <sjg@juniper.net>
Cc: "O. Hartmann" <ohartmann@walstatt.org>, svn-src-head@FreeBSD.org,
svn-src-all@FreeBSD.org, src-committers@FreeBSD.org,
Cy Schubert <Cy.Schubert@komquats.com>
Message-ID: <0b1ad34d-bc2f-c0fb-5ed3-68d07f4a7aac@FreeBSD.org>
Subject: Re: svn commit: r325404 - head/share/mk
References: <201711042102.vA4L2RuR063978@repo.freebsd.org>
<20171104223133.00f5bf30@thor.intern.walstatt.dynvpn.de>
<20171105111644.4c294342@thor.intern.walstatt.dynvpn.de>
<7d0c021d-fe3d-9bea-b088-5e530176288b@FreeBSD.org>
<13707.1509899195@kaos.jnpr.net>
In-Reply-To: <13707.1509899195@kaos.jnpr.net>
--T9L9mboiQXoHsEmc0EVPFO9rBvo7FhW9h
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 11/5/2017 8:26 AM, Simon J. Gerraty wrote:
> Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>>> ${.OBJDIR} =3D=3D /${RELDIR})) make[6]: Fatal errors encountered -- c=
annot continue make[6]:
>>> stopped
>>> in /usr/obj/usr/src/amd64.amd64/sys/THOR/usr/ports/emulators/virtualb=
ox-ose-kmod/work/VirtualBox-5.2.0/out/freebsd.amd64/release/bin/src/vboxd=
rv
>>> *** Error code 1
>>
>> Weird, can you try this please? http://dpaste.com/3HR1EQH.txt
>>
>=20
> That will work, but you could remove the check for SRCTOP since it isn'=
t
> used in the conditional.
>=20
> FWIW this is happening because make is being run from within OBJTOP
> during kernel module build, and thus the logic in src.sys.env.mk
> isn't defining RELDIR.
>=20
> If OBJTOP were defined (it is in my case) the following
> which is similar to what we have in our internal trees
> would fix it.
>=20
> In the FreeBSD tree though OBJTOP may not defined until some time later=
=2E
> And if you want to .export it you need to use .export-env and play game=
s
> to get it into a form that will work as TARGET_SPEC_VARS change values.=
>=20
> Index: share/mk/src.sys.env.mk
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- share/mk/src.sys.env.mk (revision 325436)
> +++ share/mk/src.sys.env.mk (working copy)
> @@ -10,6 +10,8 @@
> RELTOP=3D .
> .elif ${.CURDIR:M${SRCTOP}/*}
> RELDIR:=3D ${.CURDIR:S,${SRCTOP}/,,}
> +.elif ${.CURDIR:M${OBJTOP}/*}
> +RELDIR:=3D ${.CURDIR:S,${OBJTOP}/,,}
> .endif
> RELTOP?=3D ${RELDIR:C,[^/]+,..,g}
> RELOBJTOP?=3D ${RELTOP}
>=20
I only find RELDIR useful in the non-kernel builds, so I don't really
care to extend it here.
--=20
Regards,
Bryan Drewery
--T9L9mboiQXoHsEmc0EVPFO9rBvo7FhW9h--
--QNokupXj5FohTNa4AmPgigvakF7NgGPWX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJZ/zydAAoJEDXXcbtuRpfPQn4IANSOUvYWoR/Ek+AGO2LTZWZ2
rZx7lDCDezHMUEeHVVIaHpCHVx0FNrfVi7TnsScyO8ps/jb8pzk+jFW0JXabAeAg
8s4bafwTJnimzNIXcBQzmOcPae+lXeFoDXRi/6SN+zsfWGrnTsMp/NCx8feursVO
V8IRCdieigk7mMbZN4O7EO/lnrn0iNJuhWpI0XsdlMwF26+FYkI1FwfijFj9PUjA
IPWMcsU6C6tDf0+BoVPxMUWymHCam39P+vgKtPnX0c9oZQNQ+ng/4xXVZMj8//Ce
Ztp0yqOLxDFFfvx6tenMJOF9t3gwbsgu0Z9b626TWcjeuRqUIeRo6EunXEFWV40=
=zLf9
-----END PGP SIGNATURE-----
--QNokupXj5FohTNa4AmPgigvakF7NgGPWX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0b1ad34d-bc2f-c0fb-5ed3-68d07f4a7aac>