From owner-svn-src-all@freebsd.org Fri May 3 14:49:53 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB64A1592526; Fri, 3 May 2019 14:49:53 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670069.outbound.protection.outlook.com [40.107.67.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 37DE37483B; Fri, 3 May 2019 14:49:52 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQBPR0101MB2260.CANPRD01.PROD.OUTLOOK.COM (52.132.70.13) by YQBPR0101MB1122.CANPRD01.PROD.OUTLOOK.COM (52.132.67.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Fri, 3 May 2019 14:49:51 +0000 Received: from YQBPR0101MB2260.CANPRD01.PROD.OUTLOOK.COM ([fe80::8128:ff77:e6ac:fe1a]) by YQBPR0101MB2260.CANPRD01.PROD.OUTLOOK.COM ([fe80::8128:ff77:e6ac:fe1a%5]) with mapi id 15.20.1856.012; Fri, 3 May 2019 14:49:51 +0000 From: Rick Macklem To: Harry Schmalzbauer , Rick Macklem , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r346217 - in head/sys: fs/nfs fs/nfsclient kern sys Thread-Topic: svn commit: r346217 - in head/sys: fs/nfs fs/nfsclient kern sys Thread-Index: AQHVAY49J3ZQW8SFgUi1xSB/QpvD1aZZehTF Date: Fri, 3 May 2019 14:49:51 +0000 Message-ID: References: <201904150127.x3F1RG7X062973@repo.freebsd.org>, <8a6cb225-8644-9949-09ab-7e1525e24034@omnilan.de> In-Reply-To: <8a6cb225-8644-9949-09ab-7e1525e24034@omnilan.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d76dd1a4-fc1e-4b69-4e00-08d6cfd6990f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:YQBPR0101MB1122; x-ms-traffictypediagnostic: YQBPR0101MB1122: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1186; x-forefront-prvs: 0026334A56 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(346002)(366004)(376002)(199004)(189003)(102836004)(486006)(9686003)(6306002)(229853002)(74482002)(71200400001)(33656002)(71190400001)(14444005)(256004)(5660300002)(53936002)(76116006)(6436002)(73956011)(66446008)(64756008)(66556008)(66476007)(66946007)(68736007)(99286004)(305945005)(52536014)(76176011)(6246003)(7696005)(2906002)(6506007)(2201001)(8936002)(55016002)(316002)(86362001)(81166006)(81156014)(786003)(8676002)(2501003)(478600001)(966005)(110136005)(14454004)(446003)(46003)(476003)(74316002)(25786009)(186003)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB1122; H:YQBPR0101MB2260.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: AlV48M1Cn67xO30/dlm2VnS25z2i7B/+jq2I1a2U6z/CFW7FMXpOobDOdETf6wqu2v+iyd7TdtAx/dQQSvrLrsb2Aox2fIEdHwceebHHyr4orLdH4RCXgEZBBE7RNnQ5rV5+HAe/KgNIAs6n/nShcn+WLxOcDnO8japIbGa6CipGA8f5HKOqbWsXIMU2dvhvDN2DBUdzCj8mHuliNbfQGRgmYCtEU6uxp0VPaw/D4dGjBB8hcxoncq+OkRyWvFvy5aN/3QO0dNkSQrytDLALIMg+gAd8HtqPmIxOiS/0h1IQK4e9fUPeL71FR/Ha+JfHWvqOOZHIK9uIWxoh2QBK1Z+z8wpAVyJ68GpWzY/jQU6uDUPWR4W8L/MHcA6pFCrY2BPyYYA3XtPCpeTabIz2/nNIVqTImvDenOa6AvPOrWA= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: d76dd1a4-fc1e-4b69-4e00-08d6cfd6990f X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2019 14:49:51.6211 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB1122 X-Rspamd-Queue-Id: 37DE37483B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.976,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 14:49:54 -0000 Harry Schmalzbauer wrote: >Am 15.04.2019 um 03:27 schrieb Rick Macklem: >> Author: rmacklem >> Date: Mon Apr 15 01:27:15 2019 >> New Revision: 346217 >> URL: https://svnweb.freebsd.org/changeset/base/346217 >> >> Log: >> Fix the NFSv4 client to safely find processes. >> >> r340744 broke the NFSv4 client, because it replaced pfind_locked() wi= th a >> call to pfind(), since pfind() acquires the sx lock for the pid hash = and >> the NFSv4 already holds a mutex when it does the call. >> The patch fixes the problem by recreating a pfind_any_locked() and ad= ding the >> functions pidhash_slockall() and pidhash_sunlockall to acquire/releas= e >> all of the pid hash locks. >> These functions are then used by the NFSv4 client instead of acquirin= g >> the allproc_lock and calling pfind(). >> >> Reviewed by: kib, mjg >> MFC after: 2 weeks > >Hello, I guess as long as r340744 isn't MFCd, this commit isn't needed >in /stable/, is it? That is correct. I hadn't looked to see if r340744 was MFC'd when I did the= commit. >Any plans to MFC >https://svnweb.freebsd.org/base?view=3Drevision&revision=3D340744 >(proc: convert pfind & friends to use pidhash locks and other cleanup) No MFC is listed for the commit, so I am assuming that the author isn't pla= nning on MFC'ng it. rick