From owner-freebsd-current@FreeBSD.ORG Mon Sep 28 18:49:33 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4625106566C; Mon, 28 Sep 2009 18:49:33 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206049004.chello.pl [87.206.49.4]) by mx1.freebsd.org (Postfix) with ESMTP id 3C5338FC18; Mon, 28 Sep 2009 18:49:32 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 1EEBB456B1; Mon, 28 Sep 2009 20:49:30 +0200 (CEST) Received: from localhost (chello087206049004.chello.pl [87.206.49.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 6B04345685; Mon, 28 Sep 2009 20:49:24 +0200 (CEST) Date: Mon, 28 Sep 2009 20:49:26 +0200 From: Pawel Jakub Dawidek To: Oliver Lehmann Message-ID: <20090928184926.GA2016@garage.freebsd.pl> References: <20090927170244.0980d699.lehmann@ans-netz.de> <20090927223725.5893371f.lehmann@ans-netz.de> <20090928084035.GB1659@garage.freebsd.pl> <20090928203756.ef70e0c6.lehmann@ans-netz.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <20090928203756.ef70e0c6.lehmann@ans-netz.de> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= , freebsd-current@freebsd.org, freebsd-stable@freebsd.org Subject: Re: glabel+gmirror (8.0-RC1 problem) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Sep 2009 18:49:34 -0000 --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 28, 2009 at 08:37:56PM +0200, Oliver Lehmann wrote: > Hi Pawel, >=20 > Pawel Jakub Dawidek wrote: >=20 > > Does anything change between you upgrade from BETA3 and RC1? For example > > gmirror was compiled into the kernel before and now is loaded as module > > or something similar? >=20 > Nope, it was a clean BETA3 installation with the default GENERIC kernel > which has afaik geom_label in kernel, but not geom_mirror (nevertheless I > loaded geom_label.ko at boottime as well as geom_mirror) > The same with RC1 - clean and fresh installation with the default GENERIC > kernel and geom_label in kernel (default), but still loaded as module at > boottime as well as geom_mirror. >=20 > > Could you test this patch: > >=20 > > http://people.freebsd.org/~pjd/patches/improved_taste.patch >=20 > This makes gmirror+glabel work again on RC1 Thanks for confirmation. > One thing which I noticed. I labeled in single user mode, my root > partition with tunefs - as well as all my other partitions. After this > was done, I remounted my root partition (mount -rw /) and changed my > fstab to use the new geom labels instead. But somehow this "killed" the > new root-label of my mirror/gm0s1a partition. After I rebooted, the label > was gone and I had to manually specify the root partition > ufs:mirror/gm0s1a to mount. All the labels of my other mirrored > partitions where there (usr, tmp, var). I then rebooted once more into > single user mode (specified once more the root partition manually) and > did a tunefs -L once more. Then I rebooted directly and the label is now > there. >=20 > Is it possible that mount -rw / (which remounts /dev/mirror/gm0s1a) could > have been killed the freshly given label? Yes. tunefs(8) updates only on-disk super-block, but the kernel holds super-block that was read before. Now when you do 'mount -rw /' the in-kernel super-block is stored to the disk, and there is nothing about your label in there, so it gets overwritten. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --T4sUOijqQbZv57TR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKwQU2ForvXbEpPzQRAjsWAKD1/I40cGdT4Ihouc/aVj+Sk2XvawCeKvvu JrXOpdbXmKCd6iA/VZcN6eo= =tE+a -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--