Date: Wed, 8 Mar 2017 09:19:42 -0700 From: Warner Losh <imp@bsdimp.com> To: rgrimes@freebsd.org Cc: Hans Petter Selasky <hselasky@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r314905 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf modules/linuxkpi Message-ID: <CANCZdfpe9QOSZXcPy4juRRZgAJYqzSxOTOT8YuvxwqvzT6pfyA@mail.gmail.com> In-Reply-To: <201703081607.v28G7a6E001322@pdx.rh.CN85.dnsmgr.net> References: <201703081109.v28B9RCD000618@repo.freebsd.org> <201703081607.v28G7a6E001322@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 8, 2017 at 9:07 AM, Rodney W. Grimes <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] >> Author: hselasky >> Date: Wed Mar 8 11:09:27 2017 >> New Revision: 314905 >> URL: https://svnweb.freebsd.org/changeset/base/314905 >> >> Log: >> Cleanup the LinuxKPI slab implementation. >> >> Put large functions into linux_slab.c instead of declaring them static >> inline. >> >> Add support for more memory allocation wrappers like kmalloc_array() >> and __vmalloc(). >> >> Make sure either the M_WAITOK or the M_NOWAIT flag is set and mask >> away unused memory allocation flags before calling FreeBSD's malloc() >> routine. >> >> Move kmalloc_node() definition to slab.h where it belongs. >> >> Implement support for the SLAB_DESTROY_BY_RCU feature when creating a >> kmem_cache which basically means kmem_cache memory is freed using >> call_rcu(). >> >> MFC after: 1 week >> Sponsored by: Mellanox Technologies >> >> Added: >> head/sys/compat/linuxkpi/common/src/linux_slab.c (contents, props changed) >> Modified: >> head/sys/compat/linuxkpi/common/include/linux/gfp.h >> head/sys/compat/linuxkpi/common/include/linux/slab.h >> head/sys/conf/files >> head/sys/modules/linuxkpi/Makefile >> >> Modified: head/sys/compat/linuxkpi/common/include/linux/gfp.h >> ============================================================================== >> --- head/sys/compat/linuxkpi/common/include/linux/gfp.h Wed Mar 8 09:53:20 2017 (r314904) >> +++ head/sys/compat/linuxkpi/common/include/linux/gfp.h Wed Mar 8 11:09:27 2017 (r314905) >> @@ -168,8 +168,6 @@ gfpflags_allow_blocking(const gfp_t gfp_ >> return ((gfp_flags & (M_WAITOK | M_NOWAIT)) == M_WAITOK); >> } >> >> -#define kmalloc_node(chunk, mask, node) kmalloc(chunk, mask) >> - >> #define SetPageReserved(page) do { } while (0) /* NOP */ >> #define ClearPageReserved(page) do { } while (0) /* NOP */ >> >> >> Modified: head/sys/compat/linuxkpi/common/include/linux/slab.h >> ============================================================================== >> --- head/sys/compat/linuxkpi/common/include/linux/slab.h Wed Mar 8 09:53:20 2017 (r314904) >> +++ head/sys/compat/linuxkpi/common/include/linux/slab.h Wed Mar 8 11:09:27 2017 (r314905) >> @@ -2,7 +2,7 @@ >> * Copyright (c) 2010 Isilon Systems, Inc. >> * Copyright (c) 2010 iX Systems, Inc. >> * Copyright (c) 2010 Panasas, Inc. >> - * Copyright (c) 2013, 2014 Mellanox Technologies, Ltd. >> + * Copyright (c) 2013-2017 Mellanox Technologies, Ltd. > > Though widly seen, often miss understood, this modification technically under the copyright > law can be used to assert that you have claimed copyright on the 2014 work more than one > year after original poublication, hence the work done in 2014 now falls under different > parts of the US copyright law. A prefered form of the above dates would be > 2013-2014, 2017. Do not assert copyrights for years in which no new material was > published. Publishes is defferent than written. Do not interpret these dates > as the dates written. > > Effect of this type of error: > According to the U.S. Copyright Act, if the year date [in the copyright > notice] is more than one year later than the year in which publication first > occurred, the work is considered to have been published without any notice. This is incorrect legal advice. Please don't give out legal advice if you are not a lawyer. The copyright office's own page says you need only list the first year of publication on the list of years[*]. The project's guidance to committers for the last 20 years is to do a range of copyright dates. If you'd believe this is in error, please work with the FreeBSD Foundation to get their lawyers to offer updated guidance. Warner [*] https://www.copyright.gov/circs/circ03.pdf
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpe9QOSZXcPy4juRRZgAJYqzSxOTOT8YuvxwqvzT6pfyA>