Date: Sat, 20 Jun 2015 09:32:02 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com>, Sean Bruno <sbruno@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284535 - head/sys/kern Message-ID: <55856B52.9040802@FreeBSD.org> In-Reply-To: <20150618030715.GD2080@kib.kiev.ua> References: <201506180204.t5I24LJm079537@svn.freebsd.org> <20150618030715.GD2080@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/17/15 11:07 PM, Konstantin Belousov wrote: > On Thu, Jun 18, 2015 at 02:04:21AM +0000, Sean Bruno wrote: >> Author: sbruno >> Date: Thu Jun 18 02:04:20 2015 >> New Revision: 284535 >> URL: https://svnweb.freebsd.org/changeset/base/284535 >> >> Log: >> This change replaces the mutex with a sx lock for the interpreter list to >> avoid the problem of holding a non-sleep lock during a page fault as >> reported by witness. It also uses atomics where possible to avoid having >> to acquire the exclusive lock. In addition, it consistently uses >> memset()/memcpy() instead of bzero()/bcopy(). >> >> Differential Revision: https://reviews.freebsd.org/D1971 >> Submitted by: sson >> Reviewed by: jhb > What are the page faults during image activator run ? > Or, if the page faults are not during image activation, then where ? It took me a while to figure out while reviewing, but the exec_map memory is pageable, so the bcopy to move things around inside of it can fault. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55856B52.9040802>