From owner-svn-src-all@FreeBSD.ORG Tue Dec 28 15:20:15 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 878AC1065670; Tue, 28 Dec 2010 15:20:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 5931A8FC13; Tue, 28 Dec 2010 15:20:15 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 1622D46B1A; Tue, 28 Dec 2010 10:20:15 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id E12DE8A01D; Tue, 28 Dec 2010 10:20:13 -0500 (EST) From: John Baldwin To: Kostik Belousov Date: Tue, 28 Dec 2010 10:09:40 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20101102; KDE/4.4.5; amd64; ; ) References: <201012250842.oBP8gchA016800@svn.freebsd.org> <20101228132942.GY23098@acme.spoerlein.net> <20101228133247.GR90883@deviant.kiev.zoral.com.ua> In-Reply-To: <20101228133247.GR90883@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201012281009.41028.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 28 Dec 2010 10:20:14 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, Ulrich Sp??rlein , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r216694 - head/libexec/rtld-elf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Dec 2010 15:20:15 -0000 On Tuesday, December 28, 2010 8:32:47 am Kostik Belousov wrote: > On Tue, Dec 28, 2010 at 02:29:43PM +0100, Ulrich Sp??rlein wrote: > > On Sat, 25.12.2010 at 08:42:38 +0000, Konstantin Belousov wrote: > > > Author: kib > > > Date: Sat Dec 25 08:42:38 2010 > > > New Revision: 216694 > > > URL: http://svn.freebsd.org/changeset/base/216694 > > > > > > Log: > > > Add a hook to pass debug flags to the build of rtld when doing make in > > > the rtld directory. > > > > > > Reviewed by: kan > > > > Please revert this, $(VAR) is against style, and passing DEBUG_FLAGS is > > the canonical way to achieve what you wanted, eg. make DEBUG_FLAGS=-g is > > working just fine for me. > DEBUG_FLAGS=-g might be fine for you, but it does not do what rtld debugging > needs. Look at the -DDEBUG. > > If you want ${} instead of $(), feel free to change. Err, why can't you use 'make DEBUG_FLAGS=-DDEBUG' or 'make DEBUG_FLAGS="-g -DDEBUG"'? If you are just doing 'make DEBUG=-DDEBUG' with this change, then I agree with Ulrich, DEBUG_FLAGS is already suitable for this purpose. -- John Baldwin