Date: Sat, 15 May 2021 15:07:35 -0700 From: Elwood Downey <elwood.downey@gmail.com> To: Mark Millard <marklmi@yahoo.com> Cc: freebsd-arm@freebsd.org Subject: Re: GPIO pullups not working -- SOLVED (or at least understood) [brcm,bcm2711-gpio in compat_data correct?] Message-ID: <CAL98DL45eh%2B%2Bttk=LN4Bgk_5fHz9uDVBr-hDGJmvNofzCb0%2Bng@mail.gmail.com> In-Reply-To: <D0F2CF16-E2DB-4D8A-A153-B6BD78F6DE7A@yahoo.com> References: <CAL98DL70Zt7oV57MwNrOKakXPieu5smjR%2BNJdkUUHcBjiwdvTg@mail.gmail.com> <CAL98DL4SWGA%2Bb%2BvtfDhLna2TEmwfKnLZ2-E7-CgC%2BPvL08MvXw@mail.gmail.com> <D0F2CF16-E2DB-4D8A-A153-B6BD78F6DE7A@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000019181f05c2659768
Content-Type: text/plain; charset="UTF-8"
On Sat, May 15, 2021 at 2:43 PM Mark Millard <marklmi@yahoo.com> wrote:
> Does this mean that main's 2551d928501f 2021-02-17 commit of:
>
> diff --git a/sys/arm/broadcom/bcm2835/bcm2835_gpio.c
> b/sys/arm/broadcom/bcm2835/bcm2835_gpio.c
> index 61513df9c008..70b69eb154e8 100644
> --- a/sys/arm/broadcom/bcm2835/bcm2835_gpio.c
> +++ b/sys/arm/broadcom/bcm2835/bcm2835_gpio.c
> @@ -157,6 +157,7 @@ enum bcm_gpio_pud {
> static struct ofw_compat_data compat_data[] = {
> {"broadcom,bcm2835-gpio", 1},
> {"brcm,bcm2835-gpio", 1},
> + {"brcm,bcm2711-gpio", 1},
> {NULL, 0}
> };
>
> was inappropriate?
>
>
Assuming that code made it into 13.0-RELEASE then I would say yes because
that release does not correctly control pullups for the 2711.
--00000000000019181f05c2659768
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Sat, May 15, 2021 at 2:43 PM Mark =
Millard <<a href=3D"mailto:marklmi@yahoo.com">marklmi@yahoo.com</a>> =
wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Does this=
mean that main's 2551d928501f 2021-02-17 commit of:<br>
<br>
diff --git a/sys/arm/broadcom/bcm2835/bcm2835_gpio.c b/sys/arm/broadcom/bcm=
2835/bcm2835_gpio.c<br>
index 61513df9c008..70b69eb154e8 100644<br>
--- a/sys/arm/broadcom/bcm2835/bcm2835_gpio.c<br>
+++ b/sys/arm/broadcom/bcm2835/bcm2835_gpio.c<br>
@@ -157,6 +157,7 @@ enum bcm_gpio_pud {<br>
=C2=A0static struct ofw_compat_data compat_data[] =3D {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 {"broadcom,bcm2835-gpio",=C2=A0 =C2=
=A0 =C2=A0 =C2=A01},<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 {"brcm,bcm2835-gpio",=C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A01},<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0{"brcm,bcm2711-gpio",=C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A01},<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 {NULL,=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0}<br>
=C2=A0};<br>
<br>
was inappropriate?<br><br></blockquote><div><br></div><div>Assuming that co=
de made it into 13.0-RELEASE then I would say yes because that release does=
not correctly control pullups=C2=A0for the 2711.</div><div><br></div><div>=
<br></div></div></div>
--00000000000019181f05c2659768--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAL98DL45eh%2B%2Bttk=LN4Bgk_5fHz9uDVBr-hDGJmvNofzCb0%2Bng>