From nobody Sat May 15 22:07:35 2021 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 16F9D84F612 for ; Sat, 15 May 2021 22:07:48 +0000 (UTC) (envelope-from elwood.downey@gmail.com) Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FjKJg6y0Fz4V7V for ; Sat, 15 May 2021 22:07:47 +0000 (UTC) (envelope-from elwood.downey@gmail.com) Received: by mail-pg1-x534.google.com with SMTP id t193so2056317pgb.4 for ; Sat, 15 May 2021 15:07:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A1hNJ1TotB9RxXMDsYRMb71eOt29GOldW9KTSCB3YK8=; b=jF3sHlIuA3JBc3AOnDIxVIata0+5UQJY4drxpYppYPm7fqmNf+R0pTj1dV11SYW0W4 dybz6VWqq/jmF9IEUw2Id035ESKLN8qWeFtkUFlxLZm+3KoqMgoJ7F1sk2lYusFeLSxS BsoXHZJ21SGG9+dV/IRSfS8CoQ69XYNEEMDlwThw8tcIdVpzVLUWcF20mJK227PnOIhz XPs+8Ciibdtxy6wEtiNNLOSxxj5mbgct6He8JGGTz5TiWuBiCsIjcUB7DCmF//1Lsf74 UBo32ICH4Fi1HkWequZsARvJA3K0h87y4gEhlVnI1n1asVKyE/WczvY/4ROT2n39i2uH H4qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A1hNJ1TotB9RxXMDsYRMb71eOt29GOldW9KTSCB3YK8=; b=YX4fx0s0GwC+QhKoAEYLHCj5drb+PTQD+RCtEMG9HXxl8Jof6ww35sfZNM+CXghNuj T4ZCs0VaWyObvttGFWxm5eertHLrM3aMQEQdvas4KsHQxItsPeLtnBzViDpZIVpGuW/l e55L3cD10FHpybfK/7+8l8RUV1zB8PkGYbjEW4D+1aDelOsOT8rZa+kH7m3NEpdueEBo hPCkAQ23rygEVGfUn2ZxUdlsZLgjXCAUvikmy4WH2qZDskRV3giqBqNV445VZTa+34Dl bjR/u1ixqehn0egGUYJZKAvgQRQIGSaU3uTVRzMw2prGp6rFyccCCO+UFy45cbneNoGK kI3g== X-Gm-Message-State: AOAM5307GM0ddTdpSQ1mG6PJFxXdk2WkD+t1XB8zP+P3belNtTaac+5+ 48JSYQwuSBnyL3Puq6f1xD3TNFYmwoBOmsyFzPNROt1/qXiV/w== X-Google-Smtp-Source: ABdhPJweLA82HX+tgGJO60di0lrfDgzk1eKRY5D7o2KDzfTcXOKVaMhKQ8pt+K2MCbH1UR3WycvirDiXequUfxsnLXs= X-Received: by 2002:a05:6a00:1250:b029:2c5:7d36:759f with SMTP id u16-20020a056a001250b02902c57d36759fmr29237857pfi.13.1621116466041; Sat, 15 May 2021 15:07:46 -0700 (PDT) List-Id: Porting FreeBSD to ARM processors List-Archive: http://lists.freebsd.org/arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Elwood Downey Date: Sat, 15 May 2021 15:07:35 -0700 Message-ID: Subject: Re: GPIO pullups not working -- SOLVED (or at least understood) [brcm,bcm2711-gpio in compat_data correct?] To: Mark Millard Cc: freebsd-arm@freebsd.org Content-Type: multipart/alternative; boundary="00000000000019181f05c2659768" X-Rspamd-Queue-Id: 4FjKJg6y0Fz4V7V X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] --00000000000019181f05c2659768 Content-Type: text/plain; charset="UTF-8" On Sat, May 15, 2021 at 2:43 PM Mark Millard wrote: > Does this mean that main's 2551d928501f 2021-02-17 commit of: > > diff --git a/sys/arm/broadcom/bcm2835/bcm2835_gpio.c > b/sys/arm/broadcom/bcm2835/bcm2835_gpio.c > index 61513df9c008..70b69eb154e8 100644 > --- a/sys/arm/broadcom/bcm2835/bcm2835_gpio.c > +++ b/sys/arm/broadcom/bcm2835/bcm2835_gpio.c > @@ -157,6 +157,7 @@ enum bcm_gpio_pud { > static struct ofw_compat_data compat_data[] = { > {"broadcom,bcm2835-gpio", 1}, > {"brcm,bcm2835-gpio", 1}, > + {"brcm,bcm2711-gpio", 1}, > {NULL, 0} > }; > > was inappropriate? > > Assuming that code made it into 13.0-RELEASE then I would say yes because that release does not correctly control pullups for the 2711. --00000000000019181f05c2659768 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sat, May 15, 2021 at 2:43 PM Mark = Millard <marklmi@yahoo.com> = wrote:
Does this= mean that main's 2551d928501f 2021-02-17 commit of:

diff --git a/sys/arm/broadcom/bcm2835/bcm2835_gpio.c b/sys/arm/broadcom/bcm= 2835/bcm2835_gpio.c
index 61513df9c008..70b69eb154e8 100644
--- a/sys/arm/broadcom/bcm2835/bcm2835_gpio.c
+++ b/sys/arm/broadcom/bcm2835/bcm2835_gpio.c
@@ -157,6 +157,7 @@ enum bcm_gpio_pud {
=C2=A0static struct ofw_compat_data compat_data[] =3D {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 {"broadcom,bcm2835-gpio",=C2=A0 =C2= =A0 =C2=A0 =C2=A01},
=C2=A0 =C2=A0 =C2=A0 =C2=A0 {"brcm,bcm2835-gpio",=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A01},
+=C2=A0 =C2=A0 =C2=A0 =C2=A0{"brcm,bcm2711-gpio",=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A01},
=C2=A0 =C2=A0 =C2=A0 =C2=A0 {NULL,=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0}
=C2=A0};

was inappropriate?


Assuming that co= de made it into 13.0-RELEASE then I would say yes because that release does= not correctly control pullups=C2=A0for the 2711.

=
--00000000000019181f05c2659768--