Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 15 Jul 2015 16:26:35 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 201593] usr/src/sys/dev/iicbus/max6690.c:372: poor error checking ?
Message-ID:  <bug-201593-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201593

            Bug ID: 201593
           Summary: usr/src/sys/dev/iicbus/max6690.c:372: poor error
                    checking ?
           Product: Base System
           Version: 10.2-BETA1
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: misc
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: dcb314@hotmail.com

[usr/src/sys/dev/iicbus/max6690.c:372]: (style) Checking if unsigned variable
'temp' is less than zero.

Source code is

   temp = max6690_sensor_read(sens);
    if (temp < 0)
        return (EIO);

Function max6690_sensor_read has an int return value, which should be sanity
checked >= 0, before writing into unsigned variable temp.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-201593-8>