From owner-svn-src-all@FreeBSD.ORG Sat Jun 20 13:53:36 2015 Return-Path: Delivered-To: svn-src-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 04C29187; Sat, 20 Jun 2015 13:53:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D3EE21F0; Sat, 20 Jun 2015 13:53:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (d-69-161-105-82.cpe.metrocast.net [69.161.105.82]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 99970B91F; Sat, 20 Jun 2015 09:53:34 -0400 (EDT) Message-ID: <5585705E.9040004@FreeBSD.org> Date: Sat, 20 Jun 2015 09:53:34 -0400 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sean Bruno , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284602 - head/sys/kern References: <201506191857.t5JIvbdP094203@svn.freebsd.org> In-Reply-To: <201506191857.t5JIvbdP094203@svn.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Sat, 20 Jun 2015 09:53:34 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2015 13:53:36 -0000 On 6/19/15 2:57 PM, Sean Bruno wrote: > Author: sbruno > Date: Fri Jun 19 18:57:36 2015 > New Revision: 284602 > URL: https://svnweb.freebsd.org/changeset/base/284602 > > Log: > Feedback from commit r284535 > > davide: imgact_binmisc_clear_entry() needs to use atomic ops to remove > the enable bit. I had asked you to remove the atomics and instead use an exclusive lock in the enable/disable routines as these are not hotpaths and that is simpler. Stacey agreed with that assessment in his review comment. It looks like you removed the atomics but forgot to switch the shared locks to exclusive locks. I would still prefer using exclusive locks and removing the atomics. -- John Baldwin